Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 522883002: Don't assert on empty GrGLPaths (Closed)

Created:
6 years, 3 months ago by Chris Dalton
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Kimmo Kinnunen
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't assert on empty GrGLPaths Ensure asserts aren't fired when creating a GrGLPath path from an empty SkPath. An empty path is valid and has practical use, for example, as a template path for certain nvpr calls. BUG=skia:2891 Committed: https://skia.googlesource.com/skia/+/fa3a41ff669bc720942dd059e0a0717f303af46d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M src/gpu/gl/GrGLPath.cpp View 2 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Chris Dalton
6 years, 3 months ago (2014-08-29 18:50:43 UTC) #2
bsalomon
lgtm
6 years, 3 months ago (2014-08-29 19:11:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/522883002/1
6 years, 3 months ago (2014-08-29 19:11:45 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 19:18:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as fa3a41ff669bc720942dd059e0a0717f303af46d

Powered by Google App Engine
This is Rietveld 408576698