Chromecast fix: MetricsStateManager segfaults if callbacks are empty.

chromecast/metrics/cast_metrics_unittest.cc

Index: chromecast/metrics/cast_metrics_unittest.cc
diff --git a/chromecast/metrics/cast_metrics_unittest.cc b/chromecast/metrics/cast_metrics_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e22e9e9e4c5d62df34c020929078ec057d5b92aa
--- /dev/null
+++ b/chromecast/metrics/cast_metrics_unittest.cc
@@ -0,0 +1,40 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/prefs/testing_pref_service.h"
+#include "chromecast/metrics/cast_metrics_service_client.h"
+#include "components/metrics/metrics_service.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromecast {
+
+class CastMetricsTest : public testing::Test {
+ public:
+  CastMetricsTest() {}

[lcwu1, 2014/08/29 18:39:24]

We should add a virtual destructor here.

[gunsch, 2014/08/29 18:52:01]

Done.

+
+ protected:
+  virtual void SetUp() OVERRIDE {
+    message_loop_.reset(new base::MessageLoop());
+    prefs_.reset(new TestingPrefServiceSimple());
+    ::metrics::MetricsService::RegisterPrefs(prefs_->registry());
+  }
+
+  TestingPrefServiceSimple* prefs() { return prefs_.get(); }
+
+ private:
+  scoped_ptr<base::MessageLoop> message_loop_;
+  scoped_ptr<TestingPrefServiceSimple> prefs_;
+
+  DISALLOW_COPY_AND_ASSIGN(CastMetricsTest);
+};
+
+TEST_F(CastMetricsTest, CreateMetricsServiceClient) {
+  // Create and expect this to not crash.
+  metrics::CastMetricsServiceClient::Create(prefs(), NULL);
+}
+
+}  // namespace chromecast