Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1968)

Issue 522843002: Revert of ui: Move ui_unittests.gyp into ui/base. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, Ben Goodger (Google), danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of ui: Move ui_unittests.gyp into ui/base. (patchset #5 id:80001 of https://codereview.chromium.org/506483002/) Reason for revert: it breaks clobber build of ios_dbg_simulator. Original issue's description: > ui: Move ui_unittests.gyp into ui/base. > > ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern). > ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi > ui_unittests.isolate -> ui_base_tests.isolate > > Add a TODO assigned to me to rename ui_unittests target to > ui_base_unittests when buildbot is updated. > > BUG=331829, 373148, 299841, 103304 > TEST=ui_unittests > R=sky@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/60f6892f7223f9d6db92314edb5df9b63d25720f TBR=sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=331829, 373148, 299841, 103304 Committed: https://crrev.com/6297a2f1e441c46d6f8ca37a3798fe6fbdd6cc4c Cr-Commit-Position: refs/heads/master@{#292657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -351 lines) Patch
M build/all.gyp View 11 chunks +10 lines, -10 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
D ui/base/ui_base_tests.gyp View 1 chunk +0 lines, -266 lines 0 comments Download
D ui/base/ui_base_tests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/base/ui_base_tests_bundle.gypi View 1 chunk +0 lines, -55 lines 0 comments Download
A ui/ui_unittests.gyp View 1 chunk +260 lines, -0 lines 0 comments Download
A ui/ui_unittests.isolate View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/ui_unittests_bundle.gypi View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Created Revert of ui: Move ui_unittests.gyp into ui/base.
6 years, 3 months ago (2014-08-29 17:00:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/522843002/1
6 years, 3 months ago (2014-08-29 17:01:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8aab73d59736274f3a52f5a92248af919dd0ff5a
6 years, 3 months ago (2014-08-29 17:02:11 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6297a2f1e441c46d6f8ca37a3798fe6fbdd6cc4c
Cr-Commit-Position: refs/heads/master@{#292657}

Powered by Google App Engine
This is Rietveld 408576698