Chromium Code Reviews

Issue 522813002: Add gamma/sRGB tag to SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add gamma/sRGB tag to SkImageInfo This reverts commit 64ba5fa1ff428858f803523257cd862f8b33423b. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+240 lines, -46 lines)
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments
M include/core/SkImageInfo.h View 4 chunks +64 lines, -25 lines 0 comments
M src/core/SkImageInfo.cpp View 2 chunks +111 lines, -21 lines 0 comments
A tests/ImageInfoTest.cpp View 1 chunk +64 lines, -0 lines 0 comments

Messages

Total messages: 5 (1 generated)
reed2
lgtm
6 years, 3 months ago (2014-09-01 19:06:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/522813002/1
6 years, 3 months ago (2014-09-01 19:06:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as c89aa509d6a094bc1b18d73135343819903a9cfb
6 years, 3 months ago (2014-09-01 19:14:34 UTC) #4
reed2
6 years, 3 months ago (2014-09-01 21:27:51 UTC) #5
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/525113005/ by reed@chromium.org.

The reason for reverting is: seems to be breaking layout tests in roll.

Powered by Google App Engine