Issue 522813002: Add gamma/sRGB tag to SkImageInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 522813002: Add gamma/sRGB tag to SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed1

Modified:
6 years, 3 months ago

Reviewers:
reed2

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add gamma/sRGB tag to SkImageInfo This reverts commit 64ba5fa1ff428858f803523257cd862f8b33423b. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+240 lines, -46 lines)			Patch
M	gyp/tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkImageInfo.h	View	4 chunks	+64 lines, -25 lines	0 comments	Download
M	src/core/SkImageInfo.cpp	View	2 chunks	+111 lines, -21 lines	0 comments	Download
A	tests/ImageInfoTest.cpp	View	1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/522813002/1

6 years, 3 months ago (2014-09-01 19:06:38 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as c89aa509d6a094bc1b18d73135343819903a9cfb

6 years, 3 months ago (2014-09-01 19:14:34 UTC) #4

reed2

6 years, 3 months ago (2014-09-01 21:27:51 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/525113005/ by reed@chromium.org.

The reason for reverting is: seems to be breaking layout tests in roll.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages