Source/core/html/shadow/PluginPlaceholderElement.idl - Issue 522783002: Add a custom element to own structure of shadow DOM plugin placeholders.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/shadow/PluginPlaceholderElement.idl

Issue 522783002: Add a custom element to own structure of shadow DOM plugin placeholders. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Blink-in-JS Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/html/shadow/PluginPlaceholderElement.cpp ('K') | « Source/core/html/shadow/PluginPlaceholderElement.cpp ('k') | Source/core/html/shadow/PluginPlaceholderElement.js » ('j') | Source/core/html/shadow/PluginPlaceholderElement.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 NoInterfaceObject

	7 ] interface PluginPlaceholderElement : HTMLDivElement {

	8 [ImplementedInPrivateScript, OnlyExposedToPrivateScript] attribute DOMString message;

	9 [ImplementedInPrivateScript, OnlyExposedToPrivateScript] void initializePlac eholderElements();
	haraken 2014/08/31 14:53:34 Can we rename this to 'createCallback', since this Can we rename this to 'createCallback', since this should be replaced with the create callback of the custom elements in the future? jbroman 2014/08/31 16:53:49 I don't have any objections to this. I did notice Show quoted text On 2014/08/31 14:53:34, haraken wrote: > > Can we rename this to 'createCallback', since this should be replaced with the > create callback of the custom elements in the future? I don't have any objections to this. I did notice some methods with this convention in HTMLMarqueeElement, but it sounded to me like the plumbing to deal with them automatically does not exist yet. Is that correct? haraken 2014/09/01 00:47:38 Yes. Ideally both HTMLMarqueeElement and PluginPla Show quoted text On 2014/08/31 16:53:49, jbroman wrote: > On 2014/08/31 14:53:34, haraken wrote: > > > > Can we rename this to 'createCallback', since this should be replaced with the > > create callback of the custom elements in the future? > > I don't have any objections to this. I did notice some methods with this > convention in HTMLMarqueeElement, but it sounded to me like the plumbing to deal > with them automatically does not exist yet. Is that correct? Yes. Ideally both HTMLMarqueeElement and PluginPlaceholderElement should be implemented using lifecycle callbacks of custom elements, but we cannot do it at the moment due to the reason described here (https://codereview.chromium.org/394773003/#msg14).
	10 };

OLD	NEW