extensions/browser/extension_function.h - Issue 522763002: Moving capture_web_contents_function to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function.h

Issue 522763002: Moving capture_web_contents_function to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_function.h

diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h

index a10f422357198448a99cbc773081cc8b93176b00..982ec486809f1abecfba2ec78415af61fb8c451d 100644

--- a/extensions/browser/extension_function.h

+++ b/extensions/browser/extension_function.h

@@ -53,7 +53,7 @@ class Sender;

#define EXTENSION_FUNCTION_VALIDATE(test) \

do { \

if (!(test)) { \

- bad_message_ = true; \

+ this->bad_message_ = true; \

Ken Rockot(use gerrit already) 2014/09/02 21:16:21 nit: Is this really necessary?

return ValidationFailure(this); \

} \

} while (0)

@@ -64,7 +64,7 @@ class Sender;

#define EXTENSION_FUNCTION_ERROR(error) \

do { \

error_ = error; \

- bad_message_ = true; \

+ this->bad_message_ = true; \

return ValidationFailure(this); \

} while (0)