Moving capture_web_contents_function to extensions.

Moving capture_web_contents_function to extensions.

BUG=352290
Committed: https://crrev.com/b83f02affca36a2da9a8a4c77b5b5b9d5d4db7ff
Cr-Commit-Position: refs/heads/master@{#293356}

[lfg, 2014-08-29 14:35:41]

lfg@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2014-09-02 21:16:22]

Any idea why this isn't linking on Windows?

https://codereview.chromium.org/522763002/diff/1/extensions/browser/extension...
File extensions/browser/extension_function.h (right):

https://codereview.chromium.org/522763002/diff/1/extensions/browser/extension...
extensions/browser/extension_function.h:56: this->bad_message_ = true;         
\
nit: Is this really necessary?

[lfg, 2014-09-03 22:47:08]

On 2014/09/02 21:16:22, Ken Rockot wrote:
> Any idea why this isn't linking on Windows?

For some reason MSVC doesn't auto-instantiate the parent templated class. I've
explicitly instantiated it and it seems to be fixed.

>
https://codereview.chromium.org/522763002/diff/1/extensions/browser/extension...
> File extensions/browser/extension_function.h (right):
> 
>
https://codereview.chromium.org/522763002/diff/1/extensions/browser/extension...
> extensions/browser/extension_function.h:56: this->bad_message_ = true;        

> \
> nit: Is this really necessary?

Short answer: yes or it won't compile.
Long answer:

Since I've changed CaptureWebContentsFunction to be inherited as a template
parameter, clang doesn't like directly accessing the members of the parent
class, as it tries to resolve the members before instantiating the class.
Changing the access to go through the this pointer defers the resolution of the
members to after the class is already instantiated.

Another option would be to prefix the member with the parent name (i.e. in this
case T::), but since this goes through a macro, we can't have it there. The
easiest change is to just add the this-> to the member access, its simple and
doesn't change any other behavior -- it also doesn't require changing any other
code.

[Ken Rockot(use gerrit already), 2014-09-04 01:27:50]

lgtm

https://codereview.chromium.org/522763002/diff/20001/extensions/browser/api/c...
File extensions/browser/api/capture_web_contents_function.h (right):

https://codereview.chromium.org/522763002/diff/20001/extensions/browser/api/c...
extensions/browser/api/capture_web_contents_function.h:19: // This is used by
both webview.captureVisibleRegion and tabs.captureVisibleTab.
Please document T here, as it is not obvious at first glance why this is
templated or how it should be used.

[lfg, 2014-09-04 14:27:29]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-04 14:29:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lfg@chromium.org/522763002/40001

[commit-bot: I haz the power, 2014-09-04 15:30:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 15:30:03]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lfg, 2014-09-04 19:22:12]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-04 19:23:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lfg@chromium.org/522763002/40001

[commit-bot: I haz the power, 2014-09-04 21:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 21:15:44]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[lfg, 2014-09-04 21:17:25]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-04 21:19:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lfg@chromium.org/522763002/40001

[commit-bot: I haz the power, 2014-09-04 22:15:06]

Committed patchset #3 (id:40001) as fdc88dda31551a814c4db10fde638de35773a2bb

[commit-bot: I haz the power, 2014-09-10 03:33:17]

Patchset 3 (id:??) landed as
https://crrev.com/b83f02affca36a2da9a8a4c77b5b5b9d5d4db7ff
Cr-Commit-Position: refs/heads/master@{#293356}