Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 522643003: [DoDelete] Hold function name in Deletehelper::DoDelete (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DoDelete] Hold function name in Deletehelper::DoDelete Hold __FUNCTION__ in DoDelete stack to identify for which class DoDelete() is called on the core dump. BUG=393634 Committed: https://crrev.com/d332fcd494801256fdab6f70488cfef7d117da43 Cr-Commit-Position: refs/heads/master@{#293109}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M base/sequenced_task_runner_helpers.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tzik
Hi Nico. Recent Chrome hits various DoDelete crash as tracked by http://crbug.com/393634 . But each ...
6 years, 3 months ago (2014-09-03 03:28:20 UTC) #2
Nico
lgtm. Please remember to remove it again once you have your stack :-)
6 years, 3 months ago (2014-09-03 03:33:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/522643003/40001
6 years, 3 months ago (2014-09-03 03:58:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 07:02:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/12342)
6 years, 3 months ago (2014-09-03 09:13:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/522643003/40001
6 years, 3 months ago (2014-09-03 09:19:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as c7f0b95fefa64b7bb0accea8aafc3fb819bfdcc7
6 years, 3 months ago (2014-09-03 10:10:28 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:49 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d332fcd494801256fdab6f70488cfef7d117da43
Cr-Commit-Position: refs/heads/master@{#293109}

Powered by Google App Engine
This is Rietveld 408576698