Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary).

chrome/browser/supervised_user/permission_request_creator_sync.cc

Index: chrome/browser/supervised_user/permission_request_creator_sync.cc
diff --git a/chrome/browser/supervised_user/permission_request_creator_sync.cc b/chrome/browser/supervised_user/permission_request_creator_sync.cc
index 55551429d94b6f89b2ae4abb23ca845d4fa9447c..142f228b4e9e2780661d4b7195d83bccb02a3d90 100644
--- a/chrome/browser/supervised_user/permission_request_creator_sync.cc
+++ b/chrome/browser/supervised_user/permission_request_creator_sync.cc
@@ -8,6 +8,7 @@
 #include "base/values.h"
 #include "chrome/browser/supervised_user/supervised_user_settings_service.h"
 #include "chrome/browser/supervised_user/supervised_user_shared_settings_service.h"
+#include "net/base/escape.h"
 
 using base::Time;
 
@@ -37,9 +38,10 @@ PermissionRequestCreatorSync::~PermissionRequestCreatorSync() {}
 void PermissionRequestCreatorSync::CreatePermissionRequest(
     const std::string& url_requested,

[Bernhard Bauer, 2014/08/29 10:28:58]

Can you make this a GURL now?

[Marc Treib, 2014/08/29 10:36:26]

Yup. :)

     const base::Closure& callback) {
-  // Add the prefix.
+  // Escape the URL and add the prefix.
   std::string key = SupervisedUserSettingsService::MakeSplitSettingKey(
-      kSupervisedUserAccessRequestKeyPrefix, url_requested);
+      kSupervisedUserAccessRequestKeyPrefix,
+      net::EscapeQueryParamValue(url_requested, true));
 
   scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue);