Put vertical overscroll behind kScrollEndEffect flag

Put vertical overscroll behind kScrollEndEffect flag

Currently vertical overscroll is only used in the experimental scroll
end effect feature and causes issues with gmail, so putting it behind
this feature flag.

BUG=312998
TEST=Built Chrome for CrOS and confirmed that the stuttering with the
     flag off is no long present.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233068

[rharrison, 2013-10-30 15:56:34]

PTAL

Also who do you recommend for OWNERS and such for all these files?

[sadrul, 2013-10-30 16:06:50]

https://codereview.chromium.org/52263006/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/overscroll_controller.cc (right):

https://codereview.chromium.org/52263006/diff/1/content/browser/renderer_host...
content/browser/renderer_host/overscroll_controller.cc:308: new_mode =
OVERSCROLL_NONE;
This should be a separate CL from the content_switch_util change. Since that
change is in content/public/, I would recommend jam@ for owner review.

[rharrison, 2013-10-30 18:16:26]

https://codereview.chromium.org/52263006/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/overscroll_controller.cc (right):

https://codereview.chromium.org/52263006/diff/1/content/browser/renderer_host...
content/browser/renderer_host/overscroll_controller.cc:308: new_mode =
OVERSCROLL_NONE;
On 2013/10/30 16:06:50, sadrul wrote:
> This should be a separate CL from the content_switch_util change. Since that
> change is in content/public/, I would recommend jam@ for owner review.

Done.

[rharrison, 2013-11-05 14:04:57]

PTAL, changed the order I plan to land this and the CL that moves the utility
method into a common location. This CL will land first, since it is the one that
actually fixes the bug.

[sadrul, 2013-11-05 14:08:57]

lgtm

[commit-bot: I haz the power, 2013-11-05 14:10:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rharrison@chromium.org/52263006/440001

[commit-bot: I haz the power, 2013-11-05 14:49:06]

Retried try job too often on linux_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 16:52:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rharrison@chromium.org/52263006/560003

[commit-bot: I haz the power, 2013-11-05 20:20:24]

Change committed as 233068