Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 522563005: Cleanup: Remove broken BrowserPlugin::FromNode() declaration. (Closed)

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove broken BrowserPlugin::FromNode() declaration. BUG=None Test=None, internal cleanup. Committed: https://crrev.com/1113badb8206cf8e044caaf16c1157a686e92ae3 Cr-Commit-Position: refs/heads/master@{#292738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/renderer/browser_plugin/browser_plugin.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
6 years, 3 months ago (2014-08-29 23:13:04 UTC) #2
Fady Samuel
Awesome! Thanks for catching this! LGTM!
6 years, 3 months ago (2014-08-29 23:14:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/522563005/1
6 years, 3 months ago (2014-08-29 23:39:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 909eb1ddc7a7d0d364b4181a16bdab9eb4fafd6f
6 years, 3 months ago (2014-08-30 00:56:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:12:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1113badb8206cf8e044caaf16c1157a686e92ae3
Cr-Commit-Position: refs/heads/master@{#292738}

Powered by Google App Engine
This is Rietveld 408576698