tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py - Issue 522553002: Move remote platforms creation logic from android_browser_finder to platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

Issue 522553002: Move remote platforms creation logic from android_browser_finder to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android_browser_finder_unittest Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/platform/__init__.py ('K') | « tools/telemetry/telemetry/core/platform/platform_backend.py ('k') | tools/telemetry/telemetry/unittest/system_stub.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py b/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

index 6791a2f3037050b544b9da06d38ade75c9acbeb9..f2f56f96ce032bd0a7480ab0239d271a18062746 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

@@ -94,10 +94,7 @@ class TestAndroidProfilingHelperTabTestCase(tab_test_case.TabTestCase):

super(TestAndroidProfilingHelperTabTestCase, self).setUp()

# pylint: disable=W0212

browser_backend = self._browser._browser_backend

- try:

- self._device = browser_backend.adb.device()

- except AttributeError:

- pass

+ self._device = browser_backend._adb.device()

@benchmark.Enabled('android')

def testCreateSymFs(self):