tools/telemetry/telemetry/core/platform/device.py - Issue 522553002: Move remote platforms creation logic from android_browser_finder to platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/device.py

Issue 522553002: Move remote platforms creation logic from android_browser_finder to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android_browser_finder_unittest Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/platform/__init__.py ('K') | « tools/telemetry/telemetry/core/platform/cros_platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/device.py

diff --git a/tools/telemetry/telemetry/core/platform/device.py b/tools/telemetry/telemetry/core/platform/device.py

index bb21a1e4530620eb023a99250846930731211ebe..091f7a3e2e54c85d3d70d97cbc8682ab9791edef 100644

--- a/tools/telemetry/telemetry/core/platform/device.py

+++ b/tools/telemetry/telemetry/core/platform/device.py

@@ -1,7 +1,6 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-import logging as real_logging

class Device(object):

@@ -29,5 +28,5 @@ class Device(object):

return self._guid

@classmethod

- def GetAllConnectedDevices(cls, logging=real_logging):

+ def GetAllConnectedDevices(cls):

raise NotImplementedError()