tools/telemetry/telemetry/core/platform/cros_device.py - Issue 522553002: Move remote platforms creation logic from android_browser_finder to platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/cros_device.py

Issue 522553002: Move remote platforms creation logic from android_browser_finder to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android_browser_finder_unittest Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/platform/__init__.py ('K') | « tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py ('k') | tools/telemetry/telemetry/core/platform/cros_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/cros_device.py

diff --git a/tools/telemetry/telemetry/core/platform/cros_device.py b/tools/telemetry/telemetry/core/platform/cros_device.py

index 9e5d41735bc3ae2237b97d5ef9633ab1e259f01c..3632f3c95dda52af76f86d9c9ec1ce4ef38ca81a 100644

--- a/tools/telemetry/telemetry/core/platform/cros_device.py

+++ b/tools/telemetry/telemetry/core/platform/cros_device.py

@@ -1,8 +1,6 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-import logging as real_logging

from telemetry.core.platform import device

@@ -16,7 +14,7 @@ class CrOSDevice(device.Device):

self._ssh_identity = ssh_identity

@classmethod

- def GetAllConnectedDevices(cls, logging=real_logging):

+ def GetAllConnectedDevices(cls):

return []

@property