Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 522533003: [fsp] Remove the unused streaming field. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
yoshiki, hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Remove the unused streaming field. The field is not used, so it should be removed. NOTRY=True TEST=Tested manually that Files app works correctly. BUG=408017 Committed: https://crrev.com/d90378f3bbcf60cbb940f3c9d7fc98ff6888ebd7 Cr-Commit-Position: refs/heads/master@{#292846}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -45 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 1 chunk +18 lines, -0 lines 2 comments Download
M chrome/common/extensions/api/file_browser_private.idl View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/audio_player/js/audio_player.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js View 1 6 chunks +5 lines, -40 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
mtomasz
mtomasz@chromium.org changed reviewers: + hirono@chromium.org, yoshiki@chromium.org
6 years, 3 months ago (2014-08-29 08:12:40 UTC) #1
mtomasz
@hirono: PTAL at gallery code. @yoshiki: PTAL at audio player + metadata code. Thanks.
6 years, 3 months ago (2014-08-29 08:13:07 UTC) #2
hirono
https://codereview.chromium.org/522533003/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js File ui/file_manager/gallery/js/image_editor/image_view.js (right): https://codereview.chromium.org/522533003/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js#newcode384 ui/file_manager/gallery/js/image_editor/image_view.js:384: !navigator.onLine && !metadata.present) { metadata.drive.present?
6 years, 3 months ago (2014-08-29 10:22:54 UTC) #3
mtomasz
https://codereview.chromium.org/522533003/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js File ui/file_manager/gallery/js/image_editor/image_view.js (right): https://codereview.chromium.org/522533003/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js#newcode384 ui/file_manager/gallery/js/image_editor/image_view.js:384: !navigator.onLine && !metadata.present) { On 2014/08/29 10:22:54, hirono wrote: ...
6 years, 3 months ago (2014-09-01 00:19:44 UTC) #4
hirono
lgtm for gallery files.
6 years, 3 months ago (2014-09-01 02:21:41 UTC) #5
yoshiki
lgtm https://codereview.chromium.org/522533003/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc (right): https://codereview.chromium.org/522533003/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc#newcode110 chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:110: file_extension == ".gsheet" || file_extension == ".gslides")); (maybe ...
6 years, 3 months ago (2014-09-01 02:41:04 UTC) #6
mtomasz
https://codereview.chromium.org/522533003/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc (right): https://codereview.chromium.org/522533003/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc#newcode110 chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:110: file_extension == ".gsheet" || file_extension == ".gslides")); On 2014/09/01 ...
6 years, 3 months ago (2014-09-01 02:43:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/522533003/20001
6 years, 3 months ago (2014-09-01 02:57:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/522533003/20001
6 years, 3 months ago (2014-09-01 08:13:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f7f1771e71b8565131098b52c8455e024ab8777e
6 years, 3 months ago (2014-09-01 08:15:11 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d90378f3bbcf60cbb940f3c9d7fc98ff6888ebd7
Cr-Commit-Position: refs/heads/master@{#292846}

Powered by Google App Engine
This is Rietveld 408576698