Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 522533002: Fix build error with XCode6/OSX 10.9 SDK (Closed)

Created:
6 years, 3 months ago by Shouqun
Modified:
6 years, 3 months ago
Reviewers:
ccameron
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix build error with XCode6/OSX 10.9 SDK OpenGL/gl.h is required to be included to make the build pass. BUG= TEST= Committed: https://crrev.com/cdb1b2d2060234d2a7a766e373a5ffcefce75016 Cr-Commit-Position: refs/heads/master@{#292810}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Shouqun
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-29 03:08:20 UTC) #1
Shouqun
shouqun@chromium.org changed reviewers: + miu@chromium.org
6 years, 3 months ago (2014-08-29 04:29:51 UTC) #2
miu
miu@chromium.org changed reviewers: + ccameron@chromium.org - miu@chromium.org
6 years, 3 months ago (2014-08-29 05:32:06 UTC) #3
miu
On 2014/08/29 05:32:06, miu wrote: > mailto:miu@chromium.org changed reviewers: > + mailto:ccameron@chromium.org > - mailto:miu@chromium.org ...
6 years, 3 months ago (2014-08-29 05:33:21 UTC) #4
ccameron
This seems reasonable (as long as the 10.6 builds still work). That said, I've moved ...
6 years, 3 months ago (2014-08-29 07:32:35 UTC) #5
ccameron
(and lgtm)
6 years, 3 months ago (2014-08-29 07:32:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun@chromium.org/522533002/20001
6 years, 3 months ago (2014-08-31 00:40:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001) as b323dce0c209ad5fe76334d86d36dd114d0f8dc1
6 years, 3 months ago (2014-08-31 01:36:06 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:14:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdb1b2d2060234d2a7a766e373a5ffcefce75016
Cr-Commit-Position: refs/heads/master@{#292810}

Powered by Google App Engine
This is Rietveld 408576698