Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2497)

Issue 522483006: mojo: Update python API (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Update python API Update python API to use mixed case identifier for method to conform to the chromium python style guide. R=pkl@chromium.org Committed: https://crrev.com/bf2cd357fc230d28ccb9708097cc8a16aebe3e71 Cr-Commit-Position: refs/heads/master@{#292961}

Patch Set 1 #

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -141 lines) Patch
M mojo/public/python/mojo/system.pyx View 21 chunks +33 lines, -33 lines 0 comments Download
M mojo/python/system/mojo/embedder.pyx View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/python/tests/system_unittest.py View 1 5 chunks +106 lines, -106 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
qsr
6 years, 3 months ago (2014-09-02 15:05:47 UTC) #1
pkl (ping after 24h if needed)
Should I assume that "init" and "test*" are special cases? Otherwise, LGTM.
6 years, 3 months ago (2014-09-02 15:08:39 UTC) #2
qsr
On 2014/09/02 15:08:39, pklpkl wrote: > Should I assume that "init" and "test*" are special ...
6 years, 3 months ago (2014-09-02 15:11:46 UTC) #3
qsr
+blundell, as pkl@ is not a commiter.
6 years, 3 months ago (2014-09-02 15:11:58 UTC) #4
qsr
+ blundell for real this time.
6 years, 3 months ago (2014-09-02 15:12:22 UTC) #6
blundell
RSLGTM
6 years, 3 months ago (2014-09-02 15:13:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/522483006/20001
6 years, 3 months ago (2014-09-02 15:21:16 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-02 15:21:18 UTC) #11
blundell
sigh... LGTM
6 years, 3 months ago (2014-09-02 15:22:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/522483006/20001
6 years, 3 months ago (2014-09-02 15:27:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 78c37b501cc04ffb45173df2c83ff7240ed67bf3
6 years, 3 months ago (2014-09-02 18:28:11 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:32 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf2cd357fc230d28ccb9708097cc8a16aebe3e71
Cr-Commit-Position: refs/heads/master@{#292961}

Powered by Google App Engine
This is Rietveld 408576698