[Ozone-GBM] Handle GPU crashes

ui/ozone/platform/dri/dri_window_delegate_proxy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/dri/dri_window_delegate_proxy.h"
 
 #include "ui/ozone/common/gpu/ozone_gpu_messages.h"
 #include "ui/ozone/platform/dri/gpu_platform_support_host_gbm.h"
 
 namespace ui {
 
 DriWindowDelegateProxy::DriWindowDelegateProxy(
     gfx::AcceleratedWidget widget,
     GpuPlatformSupportHostGbm* sender)
-    : widget_(widget), sender_(sender) {
+    : widget_(widget), sender_(sender), has_connection_(false) {
 }
 
 DriWindowDelegateProxy::~DriWindowDelegateProxy() {
 }
 
 void DriWindowDelegateProxy::Initialize() {
-  bool status = sender_->Send(new OzoneGpuMsg_CreateWindowDelegate(widget_));
-  DCHECK(status);
+  TRACE_EVENT1("dri", "DriWindowDelegateProxy::Initialize", "widget", widget_);

[dnicoara, 2014/08/29 22:36:48]

Can I now remove the Initialize/Shutdown functions?

[alexst (slow to review), 2014/09/02 13:37:07]

Init can go, but shutdown still sends an IPC.

[dnicoara, 2014/09/03 17:17:25]

I like the symmetry so I'm going to leave it then.

+  sender_->AddChannelObserver(this);
 }
 
 void DriWindowDelegateProxy::Shutdown() {
+  TRACE_EVENT1("dri", "DriWindowDelegateProxy::Shutdown", "widget", widget_);
+  sender_->RemoveChannelObserver(this);
   bool status = sender_->Send(new OzoneGpuMsg_DestroyWindowDelegate(widget_));

[alexst (slow to review), 2014/09/02 13:37:07]

Is it possible to not have a connection here? Something wacky like we were
restarting the GPU but then decided to shut down? Or we never received
OnChannelEstablished?

[dnicoara, 2014/09/03 17:17:25]

Done.

   DCHECK(status);
 }
 
 gfx::AcceleratedWidget DriWindowDelegateProxy::GetAcceleratedWidget() {
   return widget_;
 }
 
 HardwareDisplayController* DriWindowDelegateProxy::GetController() {
   NOTREACHED();
   return NULL;
 }
 
 void DriWindowDelegateProxy::OnBoundsChanged(const gfx::Rect& bounds) {
+  TRACE_EVENT1(
+      "dri", "DriWindowDelegateProxy::OnBoundsChanged", "widget", widget_);
+  bounds_ = bounds;
+  if (!has_connection_)
+    return;
+
   bool status =
       sender_->Send(new OzoneGpuMsg_WindowBoundsChanged(widget_, bounds));
   DCHECK(status);
 }
 
+void DriWindowDelegateProxy::OnChannelEstablished() {
+  TRACE_EVENT1(
+      "dri", "DriWindowDelegateProxy::OnChannelEstablished", "widget", widget_);
+  has_connection_ = true;
+  bool status = sender_->Send(new OzoneGpuMsg_CreateWindowDelegate(widget_));
+  DCHECK(status);
+  OnBoundsChanged(bounds_);
+}
+
+void DriWindowDelegateProxy::OnChannelDestroyed() {
+  TRACE_EVENT1(
+      "dri", "DriWindowDelegateProxy::OnChannelDestroyed", "widget", widget_);
+  has_connection_ = false;
+}
+
 }  // namespace ui