Issue 522463003: Filter blacklisted forms out from the crash reports.

Issue 522463003: Filter blacklisted forms out from the crash reports. (Closed)

Created:
6 years, 3 months ago by vasilii

Modified:
6 years, 3 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Filter blacklisted forms out from the crash reports. BUG=408804 Committed: https://crrev.com/8b4bda551796999debc4412cf623694e4ad126a5 Cr-Commit-Position: refs/heads/master@{#292604}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	components/password_manager/core/browser/password_store.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

vasilii

vasilii@chromium.org changed reviewers: + vabr@chromium.org

6 years, 3 months ago (2014-08-29 09:23:34 UTC) #1

vabr (Chromium)

LGTM. Very good point about the blacklisted entries! Vaclav

6 years, 3 months ago (2014-08-29 09:37:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/522463003/1

6 years, 3 months ago (2014-08-29 09:47:21 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...

6 years, 3 months ago (2014-08-29 10:43:06 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as e2c63740f28ffa6f80582b9f50796466fb3db7b9

6 years, 3 months ago (2014-08-29 10:55:31 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:07:37 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8b4bda551796999debc4412cf623694e4ad126a5
Cr-Commit-Position: refs/heads/master@{#292604}