Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 522183002: Docserver: Rename CompiledFileSystem's GetFileVersion/GetFileListingVersion to (Closed)

Created:
6 years, 3 months ago by not at google - send to devlin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Docserver: Rename CompiledFileSystem's GetFileVersion/GetFileListingVersion to _GetFileVersionFromCache/_GetFileListingVersionFromCache, because they're protected not public methods. More importantly, make them return Futures. Plus a little more cleanup. These are small changes in preparation to the more interesting patch which addresses bug 402903. BUG=402903 TBR=yoz@chromium.org Committed: https://crrev.com/b147f5ec9548bb32b3a63dae8e063c9c65907eab Cr-Commit-Position: refs/heads/master@{#292797}

Patch Set 1 #

Patch Set 2 : remove unnecessary change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M chrome/common/extensions/docs/server2/api_models.py View 1 3 chunks +13 lines, -15 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/chained_compiled_file_system.py View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/compiled_file_system.py View 1 chunk +13 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/redirector.py View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
not at google - send to devlin
Hey Yoyo, Ken, Freddy - Sorry to be TBR'ing this but as you know I'll ...
6 years, 3 months ago (2014-08-30 16:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/522183002/20001
6 years, 3 months ago (2014-08-30 16:17:23 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4a2d86eebdcd91db7592fa8a81ac1f6bf4d61073
6 years, 3 months ago (2014-08-30 17:14:25 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:14:30 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b147f5ec9548bb32b3a63dae8e063c9c65907eab
Cr-Commit-Position: refs/heads/master@{#292797}

Powered by Google App Engine
This is Rietveld 408576698