RenderText: Always invalidate layout on style changes and never on color changes

RenderText: Always invalidate layout on style changes and never on color changes

BUG=386749
R=msw

Committed: https://crrev.com/3be7af494ea48c49efea4bb4ecf5a7cddfa8dde1
Cr-Commit-Position: refs/heads/master@{#293072}

[ckocagil, 2014-08-30 01:26:15]

PTAL

https://codereview.chromium.org/522103002/diff/1/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (left):

https://codereview.chromium.org/522103002/diff/1/ui/gfx/render_text.cc#oldcod...
ui/gfx/render_text.cc:686: #if defined(OS_WIN)
This one shouldn't be needed after http://crrev.com/214150.

https://codereview.chromium.org/522103002/diff/1/ui/gfx/render_text.cc#oldcod...
ui/gfx/render_text.cc:713: #if defined(OS_WIN)
HarfBuzz always needs invalidation on style change.

[msw, 2014-09-02 18:02:21]

Nice! LGTM

https://codereview.chromium.org/522103002/diff/1/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (left):

https://codereview.chromium.org/522103002/diff/1/ui/gfx/render_text.cc#oldcod...
ui/gfx/render_text.cc:686: #if defined(OS_WIN)
On 2014/08/30 01:26:15, ckocagil wrote:
> This one shouldn't be needed after http://crrev.com/214150.

Acknowledged.

https://codereview.chromium.org/522103002/diff/1/ui/gfx/render_text.cc#oldcod...
ui/gfx/render_text.cc:713: #if defined(OS_WIN)
On 2014/08/30 01:26:15, ckocagil wrote:
> HarfBuzz always needs invalidation on style change.

Acknowledged.

[ckocagil, 2014-09-03 01:08:06]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-09-03 01:10:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckocagil@chromium.org/522103002/1

[commit-bot: I haz the power, 2014-09-03 02:54:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-03 03:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 03:03:22]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ckocagil, 2014-09-03 03:41:50]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-09-03 03:43:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckocagil@chromium.org/522103002/1

[commit-bot: I haz the power, 2014-09-03 05:05:50]

Committed patchset #1 (id:1) as f6dd551e4273b7788d8e4ae842c39f970a1e106c

[commit-bot: I haz the power, 2014-09-10 03:23:35]

Patchset 1 (id:??) landed as
https://crrev.com/3be7af494ea48c49efea4bb4ecf5a7cddfa8dde1
Cr-Commit-Position: refs/heads/master@{#293072}