Issue 522053002: Remove implicit conversion from scoped_refptr to T*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 522053002: Remove implicit conversion from scoped_refptr to T* (Closed)

Created:
6 years, 3 months ago by meacer

Modified:
6 years, 3 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove implicit conversion from scoped_refptr to T* BUG=404334 Committed: https://crrev.com/a4429e8a296c8898d5c48702bf0361b03233919a Cr-Commit-Position: refs/heads/master@{#292757}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/common/extensions/permissions/permission_set_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

meacer

I missed this during https://codereview.chromium.org/482953003/

6 years, 3 months ago (2014-08-30 00:37:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/522053002/1

6 years, 3 months ago (2014-08-30 00:56:44 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 57ce16e4c63f04c75b860892ada8ab6a59213de1

6 years, 3 months ago (2014-08-30 02:05:19 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:13:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a4429e8a296c8898d5c48702bf0361b03233919a
Cr-Commit-Position: refs/heads/master@{#292757}