Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 522023003: handle more http error codes in wallet response (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

handle more http error codes in wallet response BUG=409867 Committed: https://crrev.com/286322730f447749524700dc80ac1b4f64811836 Cr-Commit-Position: refs/heads/master@{#293370}

Patch Set 1 #

Total comments: 5

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -27 lines) Patch
M components/autofill/content/browser/wallet/wallet_client.cc View 1 2 chunks +34 lines, -26 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client_unittest.cc View 1 3 chunks +80 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Evan Stade
https://codereview.chromium.org/522023003/diff/1/components/autofill/content/browser/wallet/wallet_client.cc File components/autofill/content/browser/wallet/wallet_client.cc (left): https://codereview.chromium.org/522023003/diff/1/components/autofill/content/browser/wallet/wallet_client.cc#oldcode591 components/autofill/content/browser/wallet/wallet_client.cc:591: if (response_code == net::HTTP_INTERNAL_SERVER_ERROR) { no changes to this ...
6 years, 3 months ago (2014-09-02 16:41:26 UTC) #2
Evan Stade
6 years, 3 months ago (2014-09-03 00:30:35 UTC) #4
Evan Stade
+dbeam
6 years, 3 months ago (2014-09-03 21:50:18 UTC) #7
Dan Beam
lgtm now that I can actually see the CL in the bug :) https://codereview.chromium.org/522023003/diff/1/components/autofill/content/browser/wallet/wallet_client.cc File ...
6 years, 3 months ago (2014-09-04 01:04:19 UTC) #8
Evan Stade
https://codereview.chromium.org/522023003/diff/1/components/autofill/content/browser/wallet/wallet_client.cc File components/autofill/content/browser/wallet/wallet_client.cc (right): https://codereview.chromium.org/522023003/diff/1/components/autofill/content/browser/wallet/wallet_client.cc#newcode611 components/autofill/content/browser/wallet/wallet_client.cc:611: StringToErrorType(error_type_string); On 2014/09/04 01:04:19, Dan Beam wrote: > unwrap ...
6 years, 3 months ago (2014-09-04 18:16:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/522023003/20001
6 years, 3 months ago (2014-09-04 18:18:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9b771ea33e161e5cdc0a92837fbf5fdd1d7d3d6d
6 years, 3 months ago (2014-09-04 23:16:58 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:33:49 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/286322730f447749524700dc80ac1b4f64811836
Cr-Commit-Position: refs/heads/master@{#293370}

Powered by Google App Engine
This is Rietveld 408576698