Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 5220007: Force pretenuring of closures that are immediately assigned to... (Closed)

Created:
10 years, 1 month ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Force pretenuring of closures that are immediately assigned to properties. For these closures we would like to be able to use constant functions and for that we need the closures allocated in old space. Committed: http://code.google.com/p/v8/source/detail?r=5866

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -42 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/codegen-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 4 chunks +11 lines, -5 lines 2 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M src/ast.h View 3 chunks +6 lines, -1 line 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M src/parser.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
10 years, 1 month ago (2010-11-19 13:13:40 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/5220007/diff/1/src/arm/codegen-arm.cc File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/5220007/diff/1/src/arm/codegen-arm.cc#newcode3107 src/arm/codegen-arm.cc:3107: bool pretenure) { bool -> PretenureFlag?
10 years, 1 month ago (2010-11-19 13:31:04 UTC) #2
Mads Ager (chromium)
10 years, 1 month ago (2010-11-22 09:56:24 UTC) #3
http://codereview.chromium.org/5220007/diff/1/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/5220007/diff/1/src/arm/codegen-arm.cc#newcode3107
src/arm/codegen-arm.cc:3107: bool pretenure) {
On 2010/11/19 13:31:04, Søren Gjesse wrote:
> bool -> PretenureFlag?

Right. I didn't find a better way of doing this. If you use a PretenureFlag here
you get inconvenient conversions elsewhere. I'll leave it like this for now.

Powered by Google App Engine
This is Rietveld 408576698