Issue 521943002: Chromecast: rm explicit constructor on CastMetricsServiceClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 521943002: Chromecast: rm explicit constructor on CastMetricsServiceClient. (Closed)

Created:
6 years, 3 months ago by gunsch

Modified:
6 years, 3 months ago

Reviewers:
lcwu1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Chromecast: rm explicit constructor on CastMetricsServiceClient. R=lcwu@chromium.org BUG=None Committed: https://crrev.com/cf7730f044f0e5384ee5aefb5dce587946f632f2 Cr-Commit-Position: refs/heads/master@{#292736}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chromecast/metrics/cast_metrics_service_client.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/521943002/1

6 years, 3 months ago (2014-08-29 23:24:48 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 8af365549fb6f7c0f9b569f12a4d2e5c2f66c7d0

6 years, 3 months ago (2014-08-30 00:47:03 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:12:26 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cf7730f044f0e5384ee5aefb5dce587946f632f2
Cr-Commit-Position: refs/heads/master@{#292736}