Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 521883003: Remove WebKitPoint (Closed)

Created:
6 years, 3 months ago by philipj_slow
Modified:
6 years, 3 months ago
Reviewers:
eseidel
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, Inactive, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -186 lines) Patch
M LayoutTests/fast/constructors/constructor-as-function-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/constructors/constructor-as-function-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/custom-constructors.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/custom-constructors-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/call-a-constructor-as-a-function.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/constructor-length.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/constructor-length-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/instanceof-XMLHttpRequest-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/script-tests/instanceof-XMLHttpRequest.js View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D Source/bindings/core/v8/custom/V8WebKitPointCustom.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/frame/WebKitPoint.h View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/core/frame/WebKitPoint.idl View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
philipj_slow
PTAL
6 years, 3 months ago (2014-09-02 19:10:21 UTC) #2
eseidel
lgtm
6 years, 3 months ago (2014-09-02 19:16:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/521883003/1
6 years, 3 months ago (2014-09-02 19:17:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/521883003/1
6 years, 3 months ago (2014-09-02 19:25:13 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 19:26:09 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181252

Powered by Google App Engine
This is Rietveld 408576698