Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 521823003: Added mailing list for device alerts. (Closed)

Created:
6 years, 3 months ago by zty
Modified:
6 years, 3 months ago
Reviewers:
navabi1, friedman, navabi
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added mailing list for device alerts. R=friedman@chromium.org, navabi@chromium.org Committed: https://crrev.com/20533738ea152a9ac7331a066866e0ffcbd0d1a4 Cr-Commit-Position: refs/heads/master@{#293323}

Patch Set 1 #

Total comments: 1

Patch Set 2 : CC Mailing List so GUTS can CC. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 1 3 chunks +7 lines, -4 lines 1 comment Download

Messages

Total messages: 30 (10 generated)
zty
please take a look
6 years, 3 months ago (2014-08-29 22:52:37 UTC) #1
friedman
https://codereview.chromium.org/521823003/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/521823003/diff/1/build/android/buildbot/bb_device_status_check.py#newcode153 build/android/buildbot/bb_device_status_check.py:153: 'chrome-android-device-alert@google.com'] I think it needs to be a CC ...
6 years, 3 months ago (2014-08-29 22:55:07 UTC) #2
zty
addressed. Please take a look.
6 years, 3 months ago (2014-09-03 21:37:52 UTC) #3
friedman
https://codereview.chromium.org/521823003/diff/20001/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/521823003/diff/20001/build/android/buildbot/bb_device_status_check.py#newcode153 build/android/buildbot/bb_device_status_check.py:153: 'chrome-android-device-alert@google.com'] Do you have to have it in the ...
6 years, 3 months ago (2014-09-03 21:42:24 UTC) #4
zty
The stupid mailing list only accept "To"
6 years, 3 months ago (2014-09-03 21:43:45 UTC) #5
friedman
On 2014/09/03 21:43:45, zty wrote: > The stupid mailing list only accept "To" lgtm
6 years, 3 months ago (2014-09-03 23:17:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
6 years, 3 months ago (2014-09-04 00:20:59 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-04 00:21:02 UTC) #10
chromium-reviews
As far as I knew, I'm a full committer... oh well.... On Wed, Sep 3, ...
6 years, 3 months ago (2014-09-04 00:30:07 UTC) #11
navabi
lgtm
6 years, 3 months ago (2014-09-04 01:21:55 UTC) #13
navabi1
lgtm
6 years, 3 months ago (2014-09-04 01:22:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
6 years, 3 months ago (2014-09-04 01:24:32 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1930)
6 years, 3 months ago (2014-09-04 02:54:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
6 years, 3 months ago (2014-09-04 07:27:20 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2065)
6 years, 3 months ago (2014-09-04 08:21:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
6 years, 3 months ago (2014-09-04 08:37:53 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2091)
6 years, 3 months ago (2014-09-04 09:21:38 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
6 years, 3 months ago (2014-09-04 18:57:50 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 92a2a31b74e357435c0e9811905f48ea8beca6df
6 years, 3 months ago (2014-09-04 19:33:59 UTC) #29
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:15 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20533738ea152a9ac7331a066866e0ffcbd0d1a4
Cr-Commit-Position: refs/heads/master@{#293323}

Powered by Google App Engine
This is Rietveld 408576698