|
|
DescriptionAdded mailing list for device alerts.
R=friedman@chromium.org, navabi@chromium.org
Committed: https://crrev.com/20533738ea152a9ac7331a066866e0ffcbd0d1a4
Cr-Commit-Position: refs/heads/master@{#293323}
Patch Set 1 #
Total comments: 1
Patch Set 2 : CC Mailing List so GUTS can CC. #
Total comments: 1
Messages
Total messages: 30 (10 generated)
please take a look
https://codereview.chromium.org/521823003/diff/1/build/android/buildbot/bb_de... File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/521823003/diff/1/build/android/buildbot/bb_de... build/android/buildbot/bb_device_status_check.py:153: 'chrome-android-device-alert@google.com'] I think it needs to be a CC so that GUTS will also CC.
addressed. Please take a look.
https://codereview.chromium.org/521823003/diff/20001/build/android/buildbot/b... File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/521823003/diff/20001/build/android/buildbot/b... build/android/buildbot/bb_device_status_check.py:153: 'chrome-android-device-alert@google.com'] Do you have to have it in the To address as well as CC for it to work, or is CC good enough?
The stupid mailing list only accept "To"
On 2014/09/03 21:43:45, zty wrote: > The stupid mailing list only accept "To" lgtm
The CQ bit was checked by zty@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
As far as I knew, I'm a full committer... oh well.... On Wed, Sep 3, 2014 at 5:21 PM, <commit-bot@chromium.org> wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer or > a provisional committer, _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. > > https://codereview.chromium.org/521823003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
navabi@google.com changed reviewers: + navabi@google.com
lgtm
lgtm
The CQ bit was checked by zty@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by zty@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by zty@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by zty@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/521823003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 92a2a31b74e357435c0e9811905f48ea8beca6df
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/20533738ea152a9ac7331a066866e0ffcbd0d1a4 Cr-Commit-Position: refs/heads/master@{#293323} |