Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 521753002: Chromecast: adds CastBrowserProcess to manage browser process entities. (Closed)

Created:
6 years, 3 months ago by gunsch
Modified:
6 years, 3 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds CastBrowserProcess to manage browser process entities. These are not appropriate for CastBrowserMainParts to manage. R=lcwu@chromium.org,byungchul@chromium.org BUG=336640 Committed: https://crrev.com/611228ee885eb89f54703e24fd547b4832d189d8 Cr-Commit-Position: refs/heads/master@{#292752}

Patch Set 1 #

Patch Set 2 : removed obsolete member #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -38 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/shell/browser/cast_browser_main_parts.h View 2 chunks +3 lines, -18 lines 0 comments Download
M chromecast/shell/browser/cast_browser_main_parts.cc View 4 chunks +14 lines, -13 lines 0 comments Download
A chromecast/shell/browser/cast_browser_process.h View 1 chunk +63 lines, -0 lines 0 comments Download
A chromecast/shell/browser/cast_browser_process.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M chromecast/shell/browser/cast_content_browser_client.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chromecast/shell/browser/cast_content_browser_client.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
gunsch
6 years, 3 months ago (2014-08-29 18:48:51 UTC) #1
byungchul
lgtm
6 years, 3 months ago (2014-08-30 00:09:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/521753002/20001
6 years, 3 months ago (2014-08-30 00:14:48 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-30 00:14:50 UTC) #6
lcwu1
lgtm
6 years, 3 months ago (2014-08-30 00:25:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/521753002/20001
6 years, 3 months ago (2014-08-30 00:28:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 574b621c5f738536eaca18e2a33b92481bbcd251
6 years, 3 months ago (2014-08-30 01:47:47 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/611228ee885eb89f54703e24fd547b4832d189d8
Cr-Commit-Position: refs/heads/master@{#292752}

Powered by Google App Engine
This is Rietveld 408576698