Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 521743002: Enable ExtensionApiTest.MessagingUserGesture test. (Closed)

Created:
6 years, 3 months ago by Zeeshan Qureshi
Modified:
6 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fakeugifortests
Project:
chromium
Visibility:
Public.

Description

Enable ExtensionApiTest.MessagingUserGesture test This test was disabled temporarily while changing how the fake UserGestureIndicator is set for tests. Depends on blink patch: https://codereview.chromium.org/518633002/ BUG=408426, 406336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Zeeshan Qureshi
+jochen PTAL. I disabled this test in https://codereview.chromium.org/518633002/ as blink will be creating 2 fake ...
6 years, 3 months ago (2014-09-03 21:26:12 UTC) #2
Zeeshan Qureshi
correction: The test was disabled in https://codereview.chromium.org/518583003/
6 years, 3 months ago (2014-09-03 21:27:07 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-04 09:42:06 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 00:14:26 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698