Issue 52173003: Do not remove HAdd with zero if the other operand is a double.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52173003: Do not remove HAdd with zero if the other operand is a double. (Closed)

Created:
7 years, 1 month ago by Yang

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne, Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Do not remove HAdd with zero if the other operand is a double. The other operand might be minus zero, and -0 + 0 = +0 R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17432

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -13 lines)			Patch
	M	src/hydrogen-instructions.cc	View		1 chunk	+9 lines, -2 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-add-minus-zero.js	View		1 chunk	+6 lines, -11 lines	0 comments	Download

Total messages: 5 (0 generated)

Erik Corry

According to Wikipedia http://en.wikipedia.org/wiki/Signed_zero 0 + -0 = 0 So it's only one way around ...

7 years, 1 month ago (2013-10-30 10:13:28 UTC) #3

Erik Corry

Ah, I see that's exactly the problem! Don't mind me, my long compilation is done ...

7 years, 1 month ago (2013-10-30 10:15:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r17432.