Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 521713002: Add some unittests for EasyUnlockScreenlockStateHandler (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add some unittests for EasyUnlockScreenlockStateHandler TEST=none BUG=none Committed: https://crrev.com/819be31cf97054abd761804f886b65a50e7ac08c Cr-Commit-Position: refs/heads/master@{#292742}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : fix android builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+607 lines, -0 lines) Patch
A chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 1 2 1 chunk +605 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tbarzic
6 years, 3 months ago (2014-08-29 18:20:33 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/521713002/diff/20001/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc File chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc (right): https://codereview.chromium.org/521713002/diff/20001/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc#newcode233 chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc:233: pref_service_->registry()->RegisterBooleanPref( nit: Can we call EasyUnlockService::RegisterProfilePrefs?
6 years, 3 months ago (2014-08-29 18:38:16 UTC) #3
tbarzic
https://codereview.chromium.org/521713002/diff/20001/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc File chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc (right): https://codereview.chromium.org/521713002/diff/20001/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc#newcode233 chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc:233: pref_service_->registry()->RegisterBooleanPref( On 2014/08/29 18:38:16, xiyuan wrote: > nit: Can ...
6 years, 3 months ago (2014-08-29 18:48:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/521713002/40001
6 years, 3 months ago (2014-08-29 18:49:53 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 22:54:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/521713002/60001
6 years, 3 months ago (2014-08-29 23:24:42 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 47d794118bf14883b3e1f92ed7587f769a5a0012
6 years, 3 months ago (2014-08-30 01:13:34 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:12:37 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/819be31cf97054abd761804f886b65a50e7ac08c
Cr-Commit-Position: refs/heads/master@{#292742}

Powered by Google App Engine
This is Rietveld 408576698