Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/cython/python_flags.py

Issue 521653002: Fix library link option generation on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch update #3 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cython/python_flags.py
diff --git a/third_party/cython/python_flags.py b/third_party/cython/python_flags.py
index 03c4ad752dfc2adaa901877b088bdfcd0659db26..542b4770c1517cdd1828b7489166fad27bbb685b 100644
--- a/third_party/cython/python_flags.py
+++ b/third_party/cython/python_flags.py
@@ -34,9 +34,13 @@ def main():
result = []
if opts.libraries:
libraries = b.get_libraries(ext)
- if sys.platform == 'darwin':
- libraries += [ '-lpython%s' % sys.version[:3] ]
- result = result + libraries
+ if sys.platform in ['darwin', 'linux2']:
+ # In case of darwin and linux prefix all libraries (if there is any)
+ # so it can be used as a compiler argument.
+ libraries = ['-l%s' % library for library in libraries]
+ if sys.platform == 'darwin':
+ libraries.append('-lpython%s' % sys.version[:3])
+ result.extend(libraries)
if opts.includes:
result = result + b.include_dirs
if opts.library_dirs:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698