third_party/cython/python_flags.py - Issue 521653002: Fix library link option generation on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/cython/python_flags.py

Issue 521653002: Fix library link option generation on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/cython/python_flags.py

diff --git a/third_party/cython/python_flags.py b/third_party/cython/python_flags.py

index 03c4ad752dfc2adaa901877b088bdfcd0659db26..9425898532275ec52a5e9239f10b79a26a1fca13 100644

--- a/third_party/cython/python_flags.py

+++ b/third_party/cython/python_flags.py

@@ -36,6 +36,8 @@ def main():

libraries = b.get_libraries(ext)

if sys.platform == 'darwin':

libraries += [ '-lpython%s' % sys.version[:3] ]

+ elif sys.platform == 'linux2':

+ libraries = [ '-l%s' % library for library in libraries ]

qsr 2014/08/29 14:24:33 This would apply to darwin too.

elecro 2014/08/29 14:40:56 So If I use the same code for darwin it would be o

result = result + libraries

if opts.includes:

result = result + b.include_dirs

« no previous file with comments | « no previous file | no next file » | no next file with comments »