Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: Source/core/css/resolver/StyleResolverState.cpp

Issue 5216392399814656: Clear StyleResolverState after each resolve. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Sync Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleResolverState.cpp
diff --git a/Source/core/css/resolver/StyleResolverState.cpp b/Source/core/css/resolver/StyleResolverState.cpp
index 9ab8a9d2cd4c2b906ef9b615fe6e46539c027f3b..f2294aaae3fa644637527cc38a49a5330fbea5e9 100644
--- a/Source/core/css/resolver/StyleResolverState.cpp
+++ b/Source/core/css/resolver/StyleResolverState.cpp
@@ -47,11 +47,23 @@ ElementResolveContext::ElementResolveContext(Element* element)
m_rootElementStyle = documentElement && element != documentElement ? documentElement->renderStyle() : documentStyle;
}
+ScopedStyleResolution::ScopedStyleResolution(StyleResolverState* state, Document* document, Element* e, RenderStyle* parentStyle, RenderRegion* regionForStyling)
esprehn 2013/07/12 20:15:27 It's funny, I would have preferred this as a neste
Jeffrey Yasskin 2013/07/12 20:49:08 'k; leaving it this way then. :)
+ : m_state(state)
+{
+ m_state->initForStyleResolve(document, e, parentStyle, regionForStyling);
+}
+
+ScopedStyleResolution::~ScopedStyleResolution()
+{
+ m_state->clear();
+}
+
void StyleResolverState::clear()
{
// FIXME: Use m_elementContent = ElementContext() instead.
m_elementContext.deprecatedPartialClear();
+ m_style = 0;
m_parentStyle = 0;
m_regionForStyling = 0;
m_elementStyleResources.clear();

Powered by Google App Engine
This is Rietveld 408576698