Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 52163002: ARM: Use loop to initialize locals when optimizing for size. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Use loop to initialize locals when optimizing for size. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17465

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use r9 as suggested by Vincent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Benedikt Meurer
PTAL
7 years, 1 month ago (2013-10-30 07:55:15 UTC) #1
vincent.belliard.fr
https://codereview.chromium.org/52163002/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/52163002/diff/1/src/arm/full-codegen-arm.cc#newcode176 src/arm/full-codegen-arm.cc:176: __ LoadRoot(ip, Heap::kUndefinedValueRootIndex); The two LoadRoot can be factorized ...
7 years, 1 month ago (2013-10-30 08:45:02 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/52163002/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/52163002/diff/1/src/arm/full-codegen-arm.cc#newcode176 src/arm/full-codegen-arm.cc:176: __ LoadRoot(ip, Heap::kUndefinedValueRootIndex); On 2013/10/30 08:45:02, vincent.belliard.fr wrote: > ...
7 years, 1 month ago (2013-10-30 08:46:53 UTC) #3
Sven Panne
lgtm
7 years, 1 month ago (2013-10-30 08:48:31 UTC) #4
vincent.belliard.fr
https://codereview.chromium.org/52163002/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/52163002/diff/1/src/arm/full-codegen-arm.cc#newcode176 src/arm/full-codegen-arm.cc:176: __ LoadRoot(ip, Heap::kUndefinedValueRootIndex); We can use an other register ...
7 years, 1 month ago (2013-10-30 08:53:55 UTC) #5
Benedikt Meurer
On 2013/10/30 08:53:55, vincent.belliard.fr wrote: > https://codereview.chromium.org/52163002/diff/1/src/arm/full-codegen-arm.cc > File src/arm/full-codegen-arm.cc (right): > > https://codereview.chromium.org/52163002/diff/1/src/arm/full-codegen-arm.cc#newcode176 > ...
7 years, 1 month ago (2013-10-30 09:18:51 UTC) #6
Sven Panne
LGTM (still :-)
7 years, 1 month ago (2013-10-30 09:43:25 UTC) #7
Benedikt Meurer
7 years, 1 month ago (2013-11-05 08:58:40 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 manually as r17465.

Powered by Google App Engine
This is Rietveld 408576698