Source/core/html/HTMLObjectElement.cpp - Issue 521603002: Do not use SubtreeStyleChange for reattachment of plugin renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 521603002: Do not use SubtreeStyleChange for reattachment of plugin renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/HTMLObjectElement/data-attr-reattach-recalc.html ('K') | « LayoutTests/fast/dom/HTMLObjectElement/data-attr-reattach-recalc-expected.txt ('k') | Source/core/html/HTMLPlugInElement.h » ('j') | Source/core/html/HTMLPlugInElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLObjectElement.cpp

diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp

index 34be9bfb75b9c9ddf00d1ca7a3dfd412055e41c2..2c7ef01d2a053c35aafab59945e2007b354e2868 100644

--- a/Source/core/html/HTMLObjectElement.cpp

+++ b/Source/core/html/HTMLObjectElement.cpp

@@ -257,7 +257,7 @@ void HTMLObjectElement::reloadPluginOnAttributeChange(const QualifiedName& name)

}

setNeedsWidgetUpdate(true);

if (needsInvalidation)

- setNeedsStyleRecalc(SubtreeStyleChange);

+ triggerReattachThroughStyleRecalcHack();

}

// FIXME: This should be unified with HTMLEmbedElement::updateWidget and

@@ -332,7 +332,7 @@ void HTMLObjectElement::childrenChanged(const ChildrenChange& change)

{

if (inDocument() && !useFallbackContent()) {

setNeedsWidgetUpdate(true);

- setNeedsStyleRecalc(SubtreeStyleChange);

+ triggerReattachThroughStyleRecalcHack();

}

HTMLPlugInElement::childrenChanged(change);

}