Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 521593002: GYP/Makefile changes for PNaCL. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

GYP/Makefile changes for PNaCL.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M Makefile.nacl View 2 chunks +12 lines, -23 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
svenpanne@chromium.org changed reviewers: + bmeurer@chromium.org
6 years, 3 months ago (2014-08-29 10:38:17 UTC) #1
Sven Panne
This is the other half of https://codereview.chromium.org/513923005/, but we can't land this at the moment, ...
6 years, 3 months ago (2014-08-29 10:38:17 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-08-29 10:38:53 UTC) #3
Sven Panne
6 years, 2 months ago (2014-10-06 08:45:11 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698