Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 521553002: Some ui/BUILD.gn fixes. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Some ui/BUILD.gn fixes. This fixes some TODOs in ui/BUILD.gn and add GN build file for third_party/mozilla. BUG=None TEST=None R=brettw@chromium.org Committed: https://crrev.com/a3affc00ced053e2013464fbcd2431cc6e05e23d Cr-Commit-Position: refs/heads/master@{#292649}

Patch Set 1 #

Total comments: 2

Patch Set 2 : mac or ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
A third_party/mozilla/BUILD.gn View 1 1 chunk +34 lines, -0 lines 0 comments Download
M ui/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 3 months ago (2014-08-29 03:35:14 UTC) #1
brettw
https://codereview.chromium.org/521553002/diff/1/third_party/mozilla/BUILD.gn File third_party/mozilla/BUILD.gn (right): https://codereview.chromium.org/521553002/diff/1/third_party/mozilla/BUILD.gn#newcode32 third_party/mozilla/BUILD.gn:32: ldflags = [ "-Wl,-ObjC" ] This is in xcode_settings ...
6 years, 3 months ago (2014-08-29 05:52:07 UTC) #2
tfarina
https://codereview.chromium.org/521553002/diff/1/third_party/mozilla/BUILD.gn File third_party/mozilla/BUILD.gn (right): https://codereview.chromium.org/521553002/diff/1/third_party/mozilla/BUILD.gn#newcode32 third_party/mozilla/BUILD.gn:32: ldflags = [ "-Wl,-ObjC" ] On 2014/08/29 05:52:06, brettw ...
6 years, 3 months ago (2014-08-29 13:04:53 UTC) #3
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 3 months ago (2014-08-29 16:04:51 UTC) #4
brettw
lgtm
6 years, 3 months ago (2014-08-29 16:04:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/521553002/20001
6 years, 3 months ago (2014-08-29 16:06:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b9b72a7ee2e8a07840a650146ec402a7048bede8
6 years, 3 months ago (2014-08-29 16:30:12 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3affc00ced053e2013464fbcd2431cc6e05e23d
Cr-Commit-Position: refs/heads/master@{#292649}

Powered by Google App Engine
This is Rietveld 408576698