Issue 521493002: Cleanup home card shadow code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 521493002: Cleanup home card shadow code. (Closed)

Created:
6 years, 3 months ago by Jun Mukai

Modified:
6 years, 3 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Cleanup home card shadow code. - Always shown during the gesture - not showning in minimized state - HomeCardView::SetState is no longer used. Remove it. BUG=408825 R=oshima@chromium.org TEST=athena_unittests Committed: https://crrev.com/95c7a1639892cb63e4fa60127c645d5c1d9cc011 Cr-Commit-Position: refs/heads/master@{#292732}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -16 lines)			Patch
	M	athena/home/home_card_impl.cc	View	1	2 chunks	+8 lines, -15 lines	0 comments	Download
	M	athena/home/home_card_unittest.cc	View	1	3 chunks	+11 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 6ef219ae5651d81fa476909354f93e001655be8f

6 years, 3 months ago (2014-08-30 00:24:18 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:12:17 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/95c7a1639892cb63e4fa60127c645d5c1d9cc011
Cr-Commit-Position: refs/heads/master@{#292732}