Hotword Audio Verification App: Adds hotwording assets and basic opt-in flow.

Adds hotwording assets and basic opt-in flow to the Hotword Audio Verification app.

BUG=390086
Committed: https://crrev.com/8b156314b9fa0a730c9a02ebb44ba7638d52aef7
Cr-Commit-Position: refs/heads/master@{#293074}

[kcarattini, 2014-08-29 01:41:13]

kcarattini@chromium.org changed reviewers:
+ benwells@chromium.org, mgiuca@chromium.org

[Matt Giuca, 2014-08-29 08:49:47]

I had a bit of a look but my eyes are too tired to read in detail, so I'll have
a better pass of it on Monday. Here are some quick comments.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html:19:
<button id="ah-no-thanks-button" >NO THANKS</button>
I think this should be internally called "ah-cancel-button"; "no thanks" is a
bit weird for a variable name.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html:19:
<button id="agree-button" class="primary">I AGREE</button>
I think these should be namespaced similar to how you have "ah-agree-button" --
perhaps "hw-agree-button".

Or, if there is no problem with conflicts, then just get rid of the "ah-"
prefix.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html:29:
<button id="finish-later-button">FINISH LATER</button>
Similarly, I think this should be called "cancel-button". Generally, any button
that clicking it closes the dialog with no effect should be internally called
"cancel" rather than naming it after the text.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/style.css (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/style.css:7: color:
rgba(0,0,0,.87);
nit: space between commas.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/style.css:12: }
nit: Blank line between all of these.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/style.css:14: color: rgb(67,
133, 244);
nit: Use #rgb style colour. (Unfortunately, #rgba is not available so you use
rgba() for that.)

[benwells, 2014-09-01 01:28:49]

looking good .. just some little things.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/flow.js (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/flow.js:12: /** @const */
var ALL_SET = 'all-set-container';
Optional nit: when I first saw "ALL_SET" i thought it would be the set with all
things in it ... or something. Maybe rename this to "FINISHED" or something.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/main.js (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/main.js:4: 
Instead of setting appWindow in the background page you can just do it here
with:

var appWindow = chrome.app.window.current();

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/manifest.json (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/manifest.json:17:
"display_in_launcher": false
Does it still appear in chrome://apps?

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/steps/all_set_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/all_set_step.html:4:
<span class="x"></span>
Can we use 'close' instead of 'x'?

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html:4:
<span class="x"></span>
Same here, can we use 'close'?

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html:5:
<span class="x"></span>
ditto

[Matt Giuca, 2014-09-01 05:35:43]

Should placeholder-loader-1x.png and placeholder-error-loader-1x.png be
animated? They look like a single frame of a rotating spinner animation.

I'm pretty happy with this now, after my comments are addressed.

Also, you should convince git not to check those images for similarity with
other images. Not only does it make the diff look weird, but apparently it will
stop the commit queue from being able to commit it. (I can help you.)

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/flow.js (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/flow.js:12: /** @const */
var ALL_SET = 'all-set-container';
Yeah, as a general comment, a lot of things in this CL are named after the
(often colloquial) text used in the interface (like "all set", "no thanks",
"finish later" and "x"). It would be best to use ordinary programming
terminology in the variable, method and HTML id names, and just use the
colloquial terminology in the user-visible strings.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html:13:
To help Google respond to you and for reliable and easy access to voice search,
you need to teach Google the sound of your voice.
nit: I think there should be a comma after "you" (maybe need to check with
whoever wrote this).

[Matt Giuca, 2014-09-01 05:37:13]

Also the commit log should be prefixed with the name of the component app so
it's clear you're adding this to an app, and not Chrome itself.

[kcarattini, 2014-09-01 06:59:08]

placeholder-* images are placeholders for some sort of animation that I will
figure out later.

Thanks,
Kendra

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/flow.js (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/flow.js:12: /** @const */
var ALL_SET = 'all-set-container';
On 2014/09/01 01:28:48, benwells wrote:
> Optional nit: when I first saw "ALL_SET" i thought it would be the set with
all
> things in it ... or something. Maybe rename this to "FINISHED" or something.

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/flow.js:12: /** @const */
var ALL_SET = 'all-set-container';
On 2014/09/01 05:35:43, Matt Giuca wrote:
> Yeah, as a general comment, a lot of things in this CL are named after the
> (often colloquial) text used in the interface (like "all set", "no thanks",
> "finish later" and "x"). It would be best to use ordinary programming
> terminology in the variable, method and HTML id names, and just use the
> colloquial terminology in the user-visible strings.

Acknowledged.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/main.js (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/main.js:4: 
On 2014/09/01 01:28:48, benwells wrote:
> Instead of setting appWindow in the background page you can just do it here
> with:
> 
> var appWindow = chrome.app.window.current();

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/manifest.json (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/manifest.json:17:
"display_in_launcher": false
On 2014/09/01 01:28:48, benwells wrote:
> Does it still appear in chrome://apps?

Does not appear to show in chrome://apps

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/steps/all_set_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/all_set_step.html:4:
<span class="x"></span>
On 2014/09/01 01:28:48, benwells wrote:
> Can we use 'close' instead of 'x'?

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html:19:
<button id="ah-no-thanks-button" >NO THANKS</button>
On 2014/08/29 08:49:47, Matt Giuca wrote:
> I think this should be internally called "ah-cancel-button"; "no thanks" is a
> bit weird for a variable name.

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html:4:
<span class="x"></span>
On 2014/09/01 01:28:48, benwells wrote:
> Same here, can we use 'close'?

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html:19:
<button id="agree-button" class="primary">I AGREE</button>
On 2014/08/29 08:49:47, Matt Giuca wrote:
> I think these should be namespaced similar to how you have "ah-agree-button"
--
> perhaps "hw-agree-button".
> 
> Or, if there is no problem with conflicts, then just get rid of the "ah-"
> prefix.

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html:5:
<span class="x"></span>
On 2014/09/01 01:28:48, benwells wrote:
> ditto

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html:13:
To help Google respond to you and for reliable and easy access to voice search,
you need to teach Google the sound of your voice.
On 2014/09/01 05:35:43, Matt Giuca wrote:
> nit: I think there should be a comma after "you" (maybe need to check with
> whoever wrote this).

I think I'll stick with what the mocks say for now. I don't imagine this is the
final version of those strings.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html:29:
<button id="finish-later-button">FINISH LATER</button>
On 2014/08/29 08:49:47, Matt Giuca wrote:
> Similarly, I think this should be called "cancel-button". Generally, any
button
> that clicking it closes the dialog with no effect should be internally called
> "cancel" rather than naming it after the text.

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/style.css (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/style.css:7: color:
rgba(0,0,0,.87);
On 2014/08/29 08:49:47, Matt Giuca wrote:
> nit: space between commas.

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/style.css:12: }
On 2014/08/29 08:49:47, Matt Giuca wrote:
> nit: Blank line between all of these.

Done.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/style.css:14: color: rgb(67,
133, 244);
On 2014/08/29 08:49:47, Matt Giuca wrote:
> nit: Use #rgb style colour. (Unfortunately, #rgba is not available so you use
> rgba() for that.)

The chromium style guide I found here says to prefer rgb() for non-gray-scale
colors:
http://www.chromium.org/developers/web-development-style-guide

[benwells, 2014-09-01 07:04:05]

lgtm

[kcarattini, 2014-09-01 07:45:52]

kcarattini@chromium.org changed reviewers:
+ bauerb@chromium.org

[kcarattini, 2014-09-01 07:45:52]

bauerb@chromium.org: Please review changes in chrome/browser/resources/... for
OWNERS approval.

[Bernhard Bauer, 2014-09-01 10:16:24]

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/flow.js (right):

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:41: * @return
{boolean} true if we have not reached the end of the flow.
What is the return value used for?

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:46: if
(this.currentStepIndex_ > this.currentFlow_.length) {
No braces around single-line bodies.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:50:
this.currentStepIndex_ = 0;
Are there other possible negative values than -1? If not, this branch isn't
necessary (the if branch above will also set the value to 0, and as it's not
possible to have a negative length, won't return false).

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:70: * Displays the
current step. If the current step is not the first step.
I think there should be a comma at the end here.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:86: window.Flow =
Flow;
Do you want to use |context| here? Or just leave the parameter out.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/main.js (right):

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/main.js:8: window.flow = new
Flow();
Is there a reason you need to put this into the global namespace?

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
File
chrome/browser/resources/hotword_audio_verification/steps/finished_step.html
(right):

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/steps/finished_step.html:7:
</div>
I would try to fit this on the previous line; it makes it easier to see where
new div's start. Same for other instances.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/steps/finished_step.html:16:
<span class="text">Recognize your voice when you say 'Ok Google'</span>
Fit this in 80 columns. Same for other instances.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/steps/finished_step.html:22:
You can change these settings at any time in the <a href="#">Chrome Settings</a>
Align with two fewer spaces.

[Matt Giuca, 2014-09-01 12:35:00]

lgtm with nits addressed and the two-letter prefix thing considered.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html:19:
<button id="agree-button" class="primary">I AGREE</button>
Is there actually a problem with name conflicts across HTML files? I don't think
there should be. So you should just be able to call these "cancel-button" and so
on, not needing a two-letter prefix.

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/style.css (right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/style.css:14: color: rgb(67,
133, 244);
On 2014/09/01 06:59:08, kcarattini wrote:
> On 2014/08/29 08:49:47, Matt Giuca wrote:
> > nit: Use #rgb style colour. (Unfortunately, #rgba is not available so you
use
> > rgba() for that.)
> 
> The chromium style guide I found here says to prefer rgb() for non-gray-scale
> colors:
> http://www.chromium.org/developers/web-development-style-guide

Acknowledged.

https://codereview.chromium.org/521483003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/style.css (right):

https://codereview.chromium.org/521483003/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/style.css:40: box-shadow: 0
0 30px rgba(0,0,0,0.3);
nit: spaces between commas (and many instances throughout this file).

[Matt Giuca, 2014-09-02 00:49:44]

slgtm

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
File
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html
(right):

https://codereview.chromium.org/521483003/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html:19:
<button id="agree-button" class="primary">I AGREE</button>
As discussed -- you said they'd be combined into a single DOM tree, so best to
keep them named apart. (No changes required.)

[kcarattini, 2014-09-02 04:37:24]

https://codereview.chromium.org/521483003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/style.css (right):

https://codereview.chromium.org/521483003/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/style.css:40: box-shadow: 0
0 30px rgba(0,0,0,0.3);
On 2014/09/01 12:35:00, Matt Giuca wrote:
> nit: spaces between commas (and many instances throughout this file).

Done.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/flow.js (right):

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:41: * @return
{boolean} true if we have not reached the end of the flow.
On 2014/09/01 10:16:23, Bernhard Bauer wrote:
> What is the return value used for?

Removed.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:46: if
(this.currentStepIndex_ > this.currentFlow_.length) {
On 2014/09/01 10:16:23, Bernhard Bauer wrote:
> No braces around single-line bodies.

Done.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:50:
this.currentStepIndex_ = 0;
On 2014/09/01 10:16:23, Bernhard Bauer wrote:
> Are there other possible negative values than -1? If not, this branch isn't
> necessary (the if branch above will also set the value to 0, and as it's not
> possible to have a negative length, won't return false).

Done.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:70: * Displays the
current step. If the current step is not the first step.
On 2014/09/01 10:16:23, Bernhard Bauer wrote:
> I think there should be a comma at the end here.

Done.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/flow.js:86: window.Flow =
Flow;
On 2014/09/01 10:16:23, Bernhard Bauer wrote:
> Do you want to use |context| here? Or just leave the parameter out.

Done.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/main.js (right):

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/main.js:8: window.flow = new
Flow();
On 2014/09/01 10:16:23, Bernhard Bauer wrote:
> Is there a reason you need to put this into the global namespace?

Done.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
File
chrome/browser/resources/hotword_audio_verification/steps/finished_step.html
(right):

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/steps/finished_step.html:7:
</div>
On 2014/09/01 10:16:24, Bernhard Bauer wrote:
> I would try to fit this on the previous line; it makes it easier to see where
> new div's start. Same for other instances.

Done.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/steps/finished_step.html:16:
<span class="text">Recognize your voice when you say 'Ok Google'</span>
On 2014/09/01 10:16:24, Bernhard Bauer wrote:
> Fit this in 80 columns. Same for other instances.

Done.

https://codereview.chromium.org/521483003/diff/50021/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/steps/finished_step.html:22:
You can change these settings at any time in the <a href="#">Chrome Settings</a>
On 2014/09/01 10:16:24, Bernhard Bauer wrote:
> Align with two fewer spaces.

Done.

[Bernhard Bauer, 2014-09-02 08:57:19]

LGTM w/ a nit:

https://codereview.chromium.org/521483003/diff/90001/chrome/browser/resources...
File
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
(right):

https://codereview.chromium.org/521483003/diff/90001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html:21:
<span class="icon"></span><span class="text">
Can you put the second <span> on a new line? Also below.

[kcarattini, 2014-09-03 01:57:40]

https://codereview.chromium.org/521483003/diff/90001/chrome/browser/resources...
File
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
(right):

https://codereview.chromium.org/521483003/diff/90001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html:21:
<span class="icon"></span><span class="text">
On 2014/09/02 08:57:19, Bernhard Bauer wrote:
> Can you put the second <span> on a new line? Also below.

Done.

[kcarattini, 2014-09-03 01:58:04]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-09-03 01:59:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kcarattini@chromium.org/521483003/130001

[commit-bot: I haz the power, 2014-09-03 05:12:45]

Committed patchset #8 (id:130001) as 4ba670ee409155ac6cc929668c4c9e76ffa1ab3e

[commit-bot: I haz the power, 2014-09-10 03:23:38]

Patchset 8 (id:??) landed as
https://crrev.com/8b156314b9fa0a730c9a02ebb44ba7638d52aef7
Cr-Commit-Position: refs/heads/master@{#293074}