Issue 521473003: More PNaCL fixes (without GYP/Makefile tweaks)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 521473003: More PNaCL fixes (without GYP/Makefile tweaks) (Closed)

Created:
6 years, 3 months ago by Sven Panne

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More PNaCL fixes (without GYP/Makefile tweaks) This is basically https://codereview.chromium.org/513923005/ with a few changes: * Makefile.nacl and v8.gyp are untouched. * MAP_NORESERVE-handling is more defensive. * Added ugly busy-wait emulation of sem_timedwait. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23513

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -30 lines)			Patch
M	src/base/platform/platform-linux.cc	View	5 chunks	+23 lines, -9 lines	0 comments	Download
M	src/base/platform/platform-posix.cc	View	4 chunks	+15 lines, -8 lines	0 comments	Download
M	src/base/platform/semaphore.cc	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	src/base/sys-info.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/d8-posix.cc	View	4 chunks	+14 lines, -3 lines	0 comments	Download
M	src/sampler.cc	View	6 chunks	+12 lines, -9 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Sven Panne

svenpanne@chromium.org changed reviewers: + bmeurer@chromium.org

6 years, 3 months ago (2014-08-29 09:31:05 UTC) #1

Sven Panne

This is one half of the other PNaCL CL, which we can (and should) land ...

6 years, 3 months ago (2014-08-29 09:31:05 UTC) #2

Sven Panne

6 years, 3 months ago (2014-08-29 09:39:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23513 (presubmit successful).