Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6171)

Unified Diff: chrome/browser/chromeos/login/lock/screen_locker.cc

Issue 521463005: Make SetState be called later when screen is unlocking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/lock/screen_locker.cc
diff --git a/chrome/browser/chromeos/login/lock/screen_locker.cc b/chrome/browser/chromeos/login/lock/screen_locker.cc
index 47eea7e0fcfb594dde1365ee3cff2912a8ff6806..a924fc0bed693b1fc3186a7ef66b877125164a51 100644
--- a/chrome/browser/chromeos/login/lock/screen_locker.cc
+++ b/chrome/browser/chromeos/login/lock/screen_locker.cc
@@ -205,17 +205,13 @@ void ScreenLocker::OnAuthSuccess(const UserContext& user_context) {
const user_manager::User* user =
user_manager::UserManager::Get()->FindUser(user_context.GetUserID());
if (user) {
- if (user->is_active()) {
- DCHECK(saved_ime_state_);
- input_method::InputMethodManager::Get()->SetState(saved_ime_state_);
- } else {
+ if (!user->is_active()) {
user_manager::UserManager::Get()->SwitchActiveUser(
Alexander Alekseev 2014/09/01 13:50:06 You need to clear saved_ime_state_ here to prevent
Shu Chen 2014/09/01 13:52:58 Done.
user_context.GetUserID());
}
} else {
NOTREACHED() << "Logged in user not found.";
}
- saved_ime_state_ = NULL;
authentication_capture_.reset(new AuthenticationParametersCapture());
authentication_capture_->user_context = user_context;
@@ -463,6 +459,10 @@ ScreenLocker::~ScreenLocker() {
VLOG(1) << "Calling session manager's HandleLockScreenDismissed D-Bus method";
DBusThreadManager::Get()->GetSessionManagerClient()->
NotifyLockScreenDismissed();
+
+ if (saved_ime_state_) {
+ input_method::InputMethodManager::Get()->SetState(saved_ime_state_);
+ }
}
void ScreenLocker::SetAuthenticator(Authenticator* authenticator) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698