Make SetState be called later when screen is unlocking.

Make SetState be called later when screen is unlocking.

The bug's root cause is SetState is called too early when screen is
unlocking and IMF thinks the current UI session is still LOCK screen so
it won't persist the active input method.

BUG=409500
TEST=Verified on Pixel.

Committed: https://crrev.com/291335572d8d59633307793ee85ffda966ac182c
Cr-Commit-Position: refs/heads/master@{#292891}

[Shu Chen, 2014-09-01 05:16:22]

shuchen@chromium.org changed reviewers:
+ alemate@chromium.org

[Shu Chen, 2014-09-01 05:16:34]

Alex, can you please review this cl? Thanks

[Alexander Alekseev, 2014-09-01 12:24:43]

https://codereview.chromium.org/521463005/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/lock/screen_locker.cc (right):

https://codereview.chromium.org/521463005/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/lock/screen_locker.cc:486:
imm->GetActiveIMEState()->EnableLockScreenLayouts();
Why do you need this change?
This breaks "User default" IME state, which is stored in UserManager.

The idea was: if we need to temporary filter active layouts, then we
create temporary state, make it active, and modify it. This way the
previous state will be unchanged.

[Shu Chen, 2014-09-01 13:37:53]

https://codereview.chromium.org/521463005/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/lock/screen_locker.cc (right):

https://codereview.chromium.org/521463005/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/lock/screen_locker.cc:486:
imm->GetActiveIMEState()->EnableLockScreenLayouts();
On 2014/09/01 12:24:43, alemate wrote:
> Why do you need this change?
> This breaks "User default" IME state, which is stored in UserManager.
> 
> The idea was: if we need to temporary filter active layouts, then we
> create temporary state, make it active, and modify it. This way the
> previous state will be unchanged.

I've reverted the change here. My original intention was to reduce the
InputMethodChange notification, as SetState() will call
ChangeInputMethodInternal().

[Alexander Alekseev, 2014-09-01 13:50:06]

https://codereview.chromium.org/521463005/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/lock/screen_locker.cc (right):

https://codereview.chromium.org/521463005/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/lock/screen_locker.cc:486:
imm->GetActiveIMEState()->EnableLockScreenLayouts();
On 2014/09/01 13:37:53, Shu Chen wrote:
> On 2014/09/01 12:24:43, alemate wrote:
> > Why do you need this change?
> > This breaks "User default" IME state, which is stored in UserManager.
> > 
> > The idea was: if we need to temporary filter active layouts, then we
> > create temporary state, make it active, and modify it. This way the
> > previous state will be unchanged.
> 
> I've reverted the change here. My original intention was to reduce the
> InputMethodChange notification, as SetState() will call
> ChangeInputMethodInternal().

SetState will not call ChangeInputMethodInternal() if curernt input method has
not changed. But it will notify InputMethodChanged() ... The latter is my
temporary solution to notify status tray that "number of active input methods
has changed". So we probably need to add another notification there and make
SetState() never notify if it has not changed.

https://codereview.chromium.org/521463005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/lock/screen_locker.cc (right):

https://codereview.chromium.org/521463005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/lock/screen_locker.cc:209:
user_manager::UserManager::Get()->SwitchActiveUser(
You need to clear saved_ime_state_ here to prevent switch to incorrect state in
destructor.

[Shu Chen, 2014-09-01 13:52:58]

https://codereview.chromium.org/521463005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/lock/screen_locker.cc (right):

https://codereview.chromium.org/521463005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/lock/screen_locker.cc:209:
user_manager::UserManager::Get()->SwitchActiveUser(
On 2014/09/01 13:50:06, alemate wrote:
> You need to clear saved_ime_state_ here to prevent switch to incorrect state
in
> destructor.

Done.

[Alexander Alekseev, 2014-09-01 13:57:06]

https://codereview.chromium.org/521463005/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/lock/screen_locker.cc (right):

https://codereview.chromium.org/521463005/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/lock/screen_locker.cc:209: saved_ime_state_ =
NULL;
If user is active, we actually _need_ to set active State in destructor ;-)

Otherwise, we call SwitchActiveUser() which will set IME State internally  and
we need to forger saved_ime_state_.

[Alexander Alekseev, 2014-09-01 13:57:19]

lgtm for CL #4.

[Shu Chen, 2014-09-01 14:31:26]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2014-09-01 14:31:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shuchen@chromium.org/521463005/60001

[commit-bot: I haz the power, 2014-09-01 19:43:54]

Committed patchset #4 (id:60001) as 5a965a8b10a6e0d0602feb0a0798d16de3f83580

[commit-bot: I haz the power, 2014-09-10 03:17:28]

Patchset 4 (id:??) landed as
https://crrev.com/291335572d8d59633307793ee85ffda966ac182c
Cr-Commit-Position: refs/heads/master@{#292891}