Docserver: Override Walk in CachingFileSystem

chrome/common/extensions/docs/server2/compiled_file_system_test.py

Index: chrome/common/extensions/docs/server2/compiled_file_system_test.py
diff --git a/chrome/common/extensions/docs/server2/compiled_file_system_test.py b/chrome/common/extensions/docs/server2/compiled_file_system_test.py
index e1b930fd358c6deb2e4b3c92fde653b9bac0fc99..7aef611abd5ec57244ad8bf2fe47432445d99be2 100755
--- a/chrome/common/extensions/docs/server2/compiled_file_system_test.py
+++ b/chrome/common/extensions/docs/server2/compiled_file_system_test.py
@@ -6,7 +6,7 @@
 import functools
 import os
 
-from compiled_file_system import CompiledFileSystem
+from compiled_file_system import Cache, CompiledFileSystem
 from copy import deepcopy
 from environment import GetAppVersion
 from file_system import FileNotFoundError
@@ -121,7 +121,8 @@ class CompiledFileSystemTest(unittest.TestCase):
                          'apps/deepdir/deeper/').Get())
 
   def testCaching(self):
-    compiled_fs = _GetTestCompiledFsCreator()(identity, CompiledFileSystemTest)
+    compiled_fs = _GetTestCompiledFsCreator()(Cache(identity),

[not at google - send to devlin, 2014/08/29 05:00:14]

Is there a way to test this new functionality?

[ahernandez, 2014/08/29 17:20:00]

The tests here serve as a sort of regression test. Since CompiledFS no longer
caches behind the scenes, I have to explicitly call Cache() on the comp_func
whenever caching is expected. Removing the Cache() call causes these tests to
fail, because they expect cached data but CompiledFS doesn't cache it.

+                                              CompiledFileSystemTest)
     self.assertEqual('404.html contents',
                      compiled_fs.GetFromFile('404.html').Get())
     self.assertEqual(set(('file.html',)),
@@ -204,7 +205,7 @@ class CompiledFileSystemTest(unittest.TestCase):
     mock_fs = MockFileSystem(TestFileSystem(_TEST_DATA))
     compiled_fs = CompiledFileSystem.Factory(
         ObjectStoreCreator.ForTest()).Create(
-            mock_fs, lambda path, contents: contents, type(self))
+            mock_fs, Cache(lambda path, contents: contents), type(self))
 
     future = compiled_fs.GetFromFile('no_file', skip_not_found=True)
     # If the file doesn't exist, then the file system is not read.