Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 521453002: Defer flushing the touch queue when all touch handlers removed (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
Reviewers:
sadrul, Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Defer flushing the touch queue when all touch handlers removed Currently, the touch event queue will flush itself when it's notified that all touch handlers have been removed. However, this effectively overrides the ack of any outstanding touch that is being handled. In particular, the touch may have been the cause of handler removal *and* been preventDefault'ed, in which case we should respect the preventDeafult. Defer flushing the queue when all handlers have been removed, instead waiting for any outstanding touch ack. Any additional pending events will be automatically flushed when the ack is received. BUG=406916 Committed: https://crrev.com/2d5f6468dd9b3ac1738f35e6de1acfc681412bf2 Cr-Commit-Position: refs/heads/master@{#292685}

Patch Set 1 #

Patch Set 2 : Tests #

Patch Set 3 : InputRouter test #

Patch Set 4 : Aura unit test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -50 lines) Patch
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 2 chunks +13 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 1 2 4 chunks +50 lines, -41 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (2 generated)
jdduke (slow)
jdduke@chromium.org changed reviewers: + rbyers@chromium.org
6 years, 3 months ago (2014-08-28 23:09:04 UTC) #1
jdduke (slow)
rbyers@: PTAL, thanks.
6 years, 3 months ago (2014-08-28 23:09:04 UTC) #2
Rick Byers
thanks! lgtm
6 years, 3 months ago (2014-08-29 15:17:26 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 3 months ago (2014-08-29 15:19:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/521453002/40001
6 years, 3 months ago (2014-08-29 15:20:49 UTC) #5
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 3 months ago (2014-08-29 15:21:12 UTC) #6
jdduke (slow)
On 2014/08/29 15:21:12, jdduke wrote: > The CQ bit was unchecked by mailto:jdduke@chromium.org Looks like ...
6 years, 3 months ago (2014-08-29 15:21:26 UTC) #7
jdduke (slow)
jdduke@chromium.org changed reviewers: + sadrul@chromium.org
6 years, 3 months ago (2014-08-29 15:28:50 UTC) #8
jdduke (slow)
sadrul@: Owner review for content/browser/renderer_host/render_widget_host_view_aura_unittest.cc? Thanks.
6 years, 3 months ago (2014-08-29 15:28:50 UTC) #9
sadrul
lgtm
6 years, 3 months ago (2014-08-29 16:21:53 UTC) #10
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 3 months ago (2014-08-29 16:25:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/521453002/60001
6 years, 3 months ago (2014-08-29 16:26:32 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-29 17:15:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/7268)
6 years, 3 months ago (2014-08-29 18:33:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/521453002/60001
6 years, 3 months ago (2014-08-29 18:39:41 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 3ac3c6536072a098ffa59651d06cd0b5ee55cec8
6 years, 3 months ago (2014-08-29 22:14:24 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:37 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2d5f6468dd9b3ac1738f35e6de1acfc681412bf2
Cr-Commit-Position: refs/heads/master@{#292685}

Powered by Google App Engine
This is Rietveld 408576698