Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 521433002: harden requirements on SkBitmapCache (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
humper
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

harden requirements on SkBitmapCache BUG=skia: Committed: https://skia.googlesource.com/skia/+/14b6aba0997a8b463eae824d770fc5ad1ab89617

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/core/SkBitmapCache.h View 2 chunks +14 lines, -1 line 0 comments Download
M src/core/SkBitmapCache.cpp View 3 chunks +6 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reed1
reed@google.com changed reviewers: + humper@google.com
6 years, 3 months ago (2014-08-29 14:10:21 UTC) #1
reed1
6 years, 3 months ago (2014-08-29 14:10:21 UTC) #2
reed1
ptal
6 years, 3 months ago (2014-08-29 15:38:08 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 3 months ago (2014-08-29 16:23:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/521433002/20001
6 years, 3 months ago (2014-08-29 16:24:55 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-08-29 16:24:55 UTC) #6
humper
On 2014/08/29 16:24:55, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
6 years, 3 months ago (2014-08-29 17:23:08 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 17:25:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 14b6aba0997a8b463eae824d770fc5ad1ab89617

Powered by Google App Engine
This is Rietveld 408576698