XHR: Abort DocumentParser on internalAbort

XHR: Abort DocumentParser on internalAbort

Before this CL, XHR didn't abort |m_responseDocumentParser| when the
request was cancelled.  This CL adds a call to |DocumentParser::stopParsing()|
to force cancel parsing when the request is aborted.

This CL also fixes |m_responseDocumentParser| destruction by moving the pointer
clear to |clearVariablesForLoading| and calling |detach()| on non-oilpan builds.

BUG=409461
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181247

[kouhei (in TOK), 2014-09-01 03:38:01]

kouhei@chromium.org changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org, tyoshino@chromium.org

[kouhei (in TOK), 2014-09-01 03:38:02]

Would you take a look?

[tyoshino (SeeGerritForStatus), 2014-09-01 05:06:06]

https://codereview.chromium.org/521403002/diff/60001/LayoutTests/http/tests/x...
File LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html
(right):

https://codereview.chromium.org/521403002/diff/60001/LayoutTests/http/tests/x...
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html:14:
})
semicolon

https://codereview.chromium.org/521403002/diff/60001/LayoutTests/http/tests/x...
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html:16:
}
semicolon

https://codereview.chromium.org/521403002/diff/60001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/521403002/diff/60001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:931: if (m_responseDocumentParser &&
m_responseDocumentParser->isStopped())
I guess you wanted

!m_responseDocumentParser->isStopped()

[kouhei (in TOK), 2014-09-01 05:16:57]

PTAL

https://codereview.chromium.org/521403002/diff/60001/LayoutTests/http/tests/x...
File LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html
(right):

https://codereview.chromium.org/521403002/diff/60001/LayoutTests/http/tests/x...
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html:14:
})
On 2014/09/01 05:06:05, tyoshino wrote:
> semicolon

Done.

https://codereview.chromium.org/521403002/diff/60001/LayoutTests/http/tests/x...
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html:16:
}
On 2014/09/01 05:06:05, tyoshino wrote:
> semicolon

Done.

https://codereview.chromium.org/521403002/diff/60001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/521403002/diff/60001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:931: if (m_responseDocumentParser &&
m_responseDocumentParser->isStopped())
On 2014/09/01 05:06:05, tyoshino wrote:
> I guess you wanted
> 
> !m_responseDocumentParser->isStopped()

Done.

[eseidel, 2014-09-02 17:09:28]

The CQ bit was checked by eseidel@chromium.org

[eseidel, 2014-09-02 17:09:29]

lgtm

[commit-bot: I haz the power, 2014-09-02 17:09:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/521403002/80001

[commit-bot: I haz the power, 2014-09-02 18:18:17]

Committed patchset #5 (id:80001) as 181247