Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/history/select_favicon_frames_unittest.cc

Issue 521393002: Fix SelectFaviconFramesTest on Nexus 5 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/select_favicon_frames_unittest.cc
diff --git a/chrome/browser/history/select_favicon_frames_unittest.cc b/chrome/browser/history/select_favicon_frames_unittest.cc
index 37651026e84b90ecf54423952b5ed79ce88b1aa7..df99c72fdc702a2e7487e02fdb20045f9701c95c 100644
--- a/chrome/browser/history/select_favicon_frames_unittest.cc
+++ b/chrome/browser/history/select_favicon_frames_unittest.cc
@@ -197,6 +197,8 @@ TEST(SelectFaviconFramesTest, _16From16_Scale2x_32_From_32) {
}
TEST(SelectFaviconFramesTest, ExactMatchBetterThanLargeBitmap) {
+ SCOPED_FAVICON_SCALE_FACTOR_1XAND2X;
+
float score1;
vector<SkBitmap> bitmaps1;
bitmaps1.push_back(MakeBitmap(SK_ColorGREEN, 48, 48));
@@ -215,6 +217,8 @@ TEST(SelectFaviconFramesTest, ExactMatchBetterThanLargeBitmap) {
}
TEST(SelectFaviconFramesTest, UpsampleABitBetterThanHugeBitmap) {
+ SCOPED_FAVICON_SCALE_FACTOR_1XAND2X;
+
float score1;
vector<SkBitmap> bitmaps1;
bitmaps1.push_back(MakeBitmap(SK_ColorGREEN, 128, 128));
@@ -245,6 +249,8 @@ TEST(SelectFaviconFramesTest, UpsampleABitBetterThanHugeBitmap) {
}
TEST(SelectFaviconFramesTest, DownsamplingBetterThanUpsampling) {
+ SCOPED_FAVICON_SCALE_FACTOR_1XAND2X;
+
float score1;
vector<SkBitmap> bitmaps1;
bitmaps1.push_back(MakeBitmap(SK_ColorGREEN, 8, 8));
@@ -261,6 +267,8 @@ TEST(SelectFaviconFramesTest, DownsamplingBetterThanUpsampling) {
}
TEST(SelectFaviconFramesTest, DownsamplingLessIsBetter) {
+ SCOPED_FAVICON_SCALE_FACTOR_1XAND2X;
+
float score1;
vector<SkBitmap> bitmaps1;
bitmaps1.push_back(MakeBitmap(SK_ColorGREEN, 34, 34));
@@ -277,6 +285,8 @@ TEST(SelectFaviconFramesTest, DownsamplingLessIsBetter) {
}
TEST(SelectFaviconFramesTest, UpsamplingLessIsBetter) {
+ SCOPED_FAVICON_SCALE_FACTOR_1XAND2X;
+
float score1;
vector<SkBitmap> bitmaps1;
bitmaps1.push_back(MakeBitmap(SK_ColorGREEN, 8, 8));
@@ -295,6 +305,8 @@ TEST(SelectFaviconFramesTest, UpsamplingLessIsBetter) {
// Test that the score is determined by the |original_sizes| parameter, not the
// |bitmaps| parameter to SelectFaviconFrames().
TEST(SelectFaviconFramesTest, ScoreDeterminedByOriginalSizes) {
+ SCOPED_FAVICON_SCALE_FACTOR_1XAND2X;
+
vector<SkBitmap> bitmaps1;
bitmaps1.push_back(MakeBitmap(SK_ColorGREEN, 16, 16));
vector<gfx::Size> sizes1;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698