Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 521393002: Fix SelectFaviconFramesTest on Nexus 5 (Closed)

Created:
6 years, 3 months ago by pkotwicz
Modified:
6 years, 3 months ago
Reviewers:
clamy, sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix SelectFaviconFramesTest on Nexus 5 BUG=407561 TEST=Tests pass in Nexus 5 Committed: https://crrev.com/68f381a7f13f8aeedc7c6601e53e036dbab55e79 Cr-Commit-Position: refs/heads/master@{#292977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/history/select_favicon_frames_unittest.cc View 6 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pkotwicz
clamy@ can you verify that this CL actually fixes the tests in question on Nexus ...
6 years, 3 months ago (2014-08-31 22:27:39 UTC) #2
clamy
Thanks! It seems to work on our test Nexus 5.
6 years, 3 months ago (2014-09-02 15:54:11 UTC) #3
pkotwicz
sky for OWNERS
6 years, 3 months ago (2014-09-02 15:55:22 UTC) #5
sky
LGTM
6 years, 3 months ago (2014-09-02 18:04:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/521393002/1
6 years, 3 months ago (2014-09-02 18:14:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as c4726c07c8967280bf972046fb0bd110f85187b0
6 years, 3 months ago (2014-09-02 19:45:56 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68f381a7f13f8aeedc7c6601e53e036dbab55e79
Cr-Commit-Position: refs/heads/master@{#292977}

Powered by Google App Engine
This is Rietveld 408576698