Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 521343002: Revert of EasyUnlock: Work around the ghost overlay from CSS animation. (Closed)

Created:
6 years, 3 months ago by xiyuan
Modified:
6 years, 3 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of EasyUnlock: Work around the ghost overlay from CSS animation. (patchset #3 id:40001 of https://codereview.chromium.org/487373002/) Reason for revert: No longer needed since underlying blink issue http://crbug.com/405250 is fixed. Original issue's description: > EasyUnlock: Work around the ghost overlay from CSS animation. > > BUG=404779 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290743 TBR=tbarzic@chromium.org NOTREECHECKS=true NOTRY=true BUG=404779 Committed: https://crrev.com/39e1410e8056e3001eafc949c2dae554ad2903bd Cr-Commit-Position: refs/heads/master@{#292816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M chrome/browser/resources/options/easy_unlock_turn_off_overlay.js View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
Created Revert of EasyUnlock: Work around the ghost overlay from CSS animation.
6 years, 3 months ago (2014-08-31 08:41:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/521343002/1
6 years, 3 months ago (2014-08-31 08:41:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 54bc61f149a2b27b864c745f080fbb7985b37ddc
6 years, 3 months ago (2014-08-31 08:44:23 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39e1410e8056e3001eafc949c2dae554ad2903bd
Cr-Commit-Position: refs/heads/master@{#292816}

Powered by Google App Engine
This is Rietveld 408576698